From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhigang Wang Subject: Re: [PATCH] Don't attach needless options when launch pygrub Date: Thu, 15 Jul 2010 11:44:58 +0800 Message-ID: <4C3E843A.9070008@oracle.com> References: <4C3D55F8.9010303@cn.fujitsu.com> <1279090052.13417.16.camel@localhost.localdomain> <4C3D6755.3020400@cn.fujitsu.com> <1279095028.24714.186.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060500020708090204040202" Return-path: In-Reply-To: <1279095028.24714.186.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: xen-devel@lists.xensource.com, Yu Zhiguo List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------060500020708090204040202 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/14/2010 04:10 PM, Ian Campbell wrote: > On Wed, 2010-07-14 at 08:29 +0100, Yu Zhiguo wrote: >> Hi Ian, >> >> Ian Campbell wrote: >>> On Wed, 2010-07-14 at 07:15 +0100, Yu Zhiguo wrote: >>>> We should always run grub if bootloader is specified, >>>> options 'kernel' and 'ramdisk' are needless. >>> >>> Not quite. If you specify both bootloader and kernel then this instructs >>> pygrub to extract the specific named file from the guest file system, >>> similarly for the ramdisk. >>> >> >> Do you mean in this case, pygrub will use specified kernel >> that lie in the filesystem of the DomU? > > I thought so, I looks like I was mistaken though. > >> I think this is good. But now pygrub's action is using the >> specified kernel in Dom0, but not run grub. > > Hmm, pygrub is certainly run, regardless of having a kernel configured > or not. What is in question is what --kernel and --ramdisk actually > cause pygrub to do and whether that is useful. > > As far as I can see the --kernel and --ramdisk options end up in the > incfg map which only used in a handful of places, most of which just > extract incfg["args"]. The only places which do not do this are the > calls to sniff_solaris and sniff_netware both of which appear to make > use of incfg["kernel"] (but not incfg["ramdisk"]). > > So it looks like specifying the kernel option in addition to bootloader > is infact useful if you are booting a Solaris or Netware domU but is > harmless/ignored otherwise. I think we need to continue to support this > use case and I don't see any particular reason to force those users to > change their configuration file syntax for this issue (if it's even an > issue, I still don't really see the problem). > > Perhaps it would be better to update pygrub so that --kernel actually > does something consistent in the non-{Solaris,Netware} case, such as > perhaps selecting the configuration entry with the match kernel path > instead of defaulting to entry 0? (e.g. make "-q --kernel=/boot/FOO" > select the entry with kernel /boot/FOO) > > It looks like --ramdisk (and the associated plumbing through xend) may > in fact be useless at this time. I'd say it is harmless to plumb it > through for consistency though -- perhaps in the future pygrub (or > another bootloader) might want to use it. > Yes. Please don't remove --kernel/--ramdisk: pygrub is not the only pv guest bootloader. Here is a pv guest boot loader we are using which grab vmlinuz/initrd from network. It uses --kernle/--ramdisk parameters. Thanks, Zhigang --------------060500020708090204040202 Content-Type: application/x-gzip; name="xenpvboot-0.1.tar.gz" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="xenpvboot-0.1.tar.gz" H4sIAHCDPkwAA+0ca3PbNjJfy1+xN62HVE6iHn4kp9ZpldhOfZfEHkluL5fLKDQJSTxTJAuQ fiSX/367AEmBesd10svUmExEAruLxe5isViAvmZhfHkeRUmtYTfrDz5LaWB5tLtLv83G7rb+ m5cHzeZO89Fuo7m713jQaG63WnsPYPfzsFMuqUgcDvDg/dgfOeFoKdy69q+0XJf0X7zdaR+r 9d9q7DUfzeh/FysfQONOuVhS/uT6//Yv9VTw+rkf1ll4CfFNMo5C41vjW3gWxTfcH40TsJ5V oIUqgxPuuAGzoRMEIJsEcCYYv2SeLXH6Y19AzKMRdyaAj0POGIhomFw5nH0PN1EKrhMikueL hPvnacLAT8AJvXrEYRJ5/vCGKtLQYxzpJWMGCeMTAdFQvjx/dQbPWci4E8Bpeh74LrzwXRYK Bg72TDVizDw4v5HgR9R/L+sf6R1FSNlJ/CiswiXjAh+gZcMc31P2PPBDSWocxcjL2EmIvysf JXBOFFPBhmlQBYSFX4/7P5+c9aHz6jX82ul2O6/6r79HWBQptrJLpij5kzjwkTDyxJ0wucGx IaGXh91nPyNG5+nxi+P+a0B5HB33Xx32enB00oUOnHa6/eNnZy86XTg9656e9A6R8R5js3JB WjOSGUrZcgYeSxw/EIj3GjUhkK3Ag7FzyVAjLvNRjeCAi3rXxI3klgk8iMKRHB7CTuX3PfhD CKOkClfcR/0mUaEKpJUro6SK49C1q7D7N+gzlA2D08BxGdSglxKB7e1GFZ5GIiHQlx1otJrN ZqPW3G48qiLFs15HGV8vmjDk3sMB82gClz5P/FAkbdkoy4vjZ4eveodteH764rKV104NvdVo 7NXwv0fQRVH87CSKtRywk6ImeRsOnNBnKA4bnjJS4YjBD+fZ009o22gkthtNnsiOFZLIuKjB v5QfgV/pvx8yr2Jf21f481OkJphENtBOIp6AuBH5Y1Q8odNK8ufEn7BpPffDUf6GHHnRpIBD 4Q79oIDFXiYIMKWZnqMKXSaKmpQHqNFzHJshRRrFSexwIU2Y2k9i0t8pVXHDMHD1GMROMhaw D28Mkphl+hNnxAQtLPXLSeCH6XuzCnqtH/oJ92x/MjIrVcApyjyUQoZNS1Hd3368lyPXEIUI TBsUvqyX+CcxGifOSngCzYbdIt8CImAC33Si14/3Bns7C8lmTZ9O2E05ZyHypUYXskTRK499 BVQmi9F71eMBO/ed0HiLonUDRwiUTeKOGW/L/jw2hMGAUAYDS7BgWIUgcrMZlUxiz+f7Zv3S 4XWehkTeq1NHZkWhUyEsO0dCpeWPZQBFC5vVQ7lRcFc1FrgFczFnaC1M8qZ1qrwD2rJNtmKz a/S1wtJ60mCpIODEucAVg5egqoAxRaMy7Q4njhOm8Wx3MQpuCjRiyYDmQCYwegydCdPg0eZx NDl3/4n80NIGqqFM5ZAOh/41IpmmglfTzhYOOTNLTUnbEa7vDwKW4HomqrBXmRIg0QUDIrqw 53y8ZhGd2VsC/5mwBVYOfu4IyZZV8FfNGNM6SvhNWbacJSkPtXluZ48W/lY1xqpyWRjIiv3m lCK7dlmcwKH8kZbHZnpwfJwy3TQkL3XIecQt85kTkgWgLqQ0YUu0IRuO7JYhy7nJv8RlAlfh zPKt7LeiTYEJQWT69NhlFUgeVfJVyM++aZZND+WVSjlV3jTewj4qrZeGJz2zzLWk6U48UqqM jwQFSLLWnI49EGwF2gKMrAkyO3mTw+fcagN4O5WxRc4+RZvBKCJOkwqSyF23jTJUrarNQmIV fbiqEf6yD40N9KKotsHaEhUYYqjA8pdMPZLXGXa0KThIdWXQMG4jfCWlN5rgFVkzk8wKBRSo K7Cmy5yNxhwoka1zWpnd2aXmJZ4wX2ftyYVHzxYi4Tzc1+YvMkXuWXd6Ja3pftmmDUoiKM6y zHAo2uaMg5TQ2jQoMN/stN9WoeS9zFoEPDIrK2SYWY3dGxz3nr74B3kYei+TrrxRMP3By5OD w7czHFFRFk3mrrosAcz3ugClGkRRbM7ytpkNTckJ+CtNudoRjMVQmJtJbkZqitL6tUbR0yZB RmGFB8bh8AmCLAZX7rWMoRa0zD2+Ouod905y71h2lpqTvL1Vo8HdiVXf6RRBprSVEpukQZRt /3Fbc6G+iDSEYq1cgaGbBnZX1aWxYBqtNt2NzXa1yeo8zYcJOW841sot7bdsP3YJamrCuGDY GPiy2GrOyks3fcXPxqY/C77W9PtH/dPlYcH6QA+VYtZN2t6XzeBR+2251zFuPVGzc1C2wH18 YiGRKjRJrTZOI9q5WmabAn3Q7IMKmZ0y/3WkmqvWuKXsbNq7qVnUVxO66sEYLe7JMIkxKoGa K+NIfMqokniqZVayoWtWoIe2X1GgVdBUYft0DDgpyOgnDo42M/FU4PZSatbcoswMvMmcy1v4 ITebJ4bxHIVHegG1HVWpE8rXjHzKVxWbQ9rtZsuEzCf9k5JZEaW/bMPopTHlA5hXwIs2Opsa jJMkbtfrpJM66SOvE7OVw3k4UhbWFe/JAhgKh6iiXdSUH+pykUGPWK4RNwJXHco5yHoMuutj z2lmFP+K8BrVEo0lzVOCZja78uwiKkCJP69o2E0FITMpNB/1LIol1bYv/y9SlPvZb0XDsx3P GyiNWibN91rtgvGQBfjsuGrrI5KIM7M6FxhlfoQF8b7ZR1UrRGUBakdGA0MrC1CXlzKDVwSj 5homuIMuXVzcggvKZPhOABmF38uIw0fiE7no8FE6YWEi5EKTJy6VdNb2pybpJ/bYJb/E3CSb 4qpLypvT2Cl5yRyPcrEi8RBiBQ+13xQXv6U+m2NikPB0HSdPGUjcvA8LKaPrISmSH8y6lD8D qrSyaAJdH/pUS8H9AE098aJQcAlJBtSJhbMEtxIe43pciHXsGte+ZkZQS0cRUVxWi34WbYgy D2NWKGH+75zsUlCxIexwY6qZm5oBtWbSW8W+STrSvNGnkGfapgUnQxXQoBDyEKeAkjAsWCYQ tUMsMbOOHT0dtwlLMzmZT+BM+k5zIdHyTmZTmkmuqEUk9QhxlqAeVeUZSbR4W06CmaiTLBie PJmaL061s1DMLXp5Fms+jTpr5KVYeDizC8tYXJVZuwXHGMtZWqwznInxV8zIErPZWoH6ikJW 2uAQL6q1zEyBkXdZhOYayqqEBIUb1kUVBhUK1otDhvkN/9wOYz0LF5U5hLUpzQ2VoJcNFKIX N8JoMUzZXOM5Z86FMWsGi6S+AXML7VrLzWZSkxFhEDlrbJzKnOlQydfzJSaTNc8GzTnOYqPJ 2tdazaAK/NZWs4IJ/jWajZSKHzpBsMD5TP2AbBLXMYWudGh1jZNPWQLuT0j16i1flef0R6iU v7By+WVo2WuOJ8dPK/wCTKrO0Qq4It4opJcFTaho/ZVyKzUtr5IJj+IneSBtYTeVRa3DIBVj a9ECMaTNbYxhjtYPzpUrbYs9XER8iGKNBHl0w/DptI72aoOBZHEwoN3aYJBxqrZuxhe//1G+ //PSuWBk4HfbB93y2dvZWXb/q7mzvT1z/2dnb+/R/f2fL1EODnv9g+PuvnHaPTw6/uc+JViM 09f9n09e7WeXgU47z/7ReX64X5iK8ctht3eMAGgyhkGhfdv45ifmjiOQqY0oDG4oM+ABHdwC ypeyJ22zAAK5t0FHRJZfK17yCzi4C1LcgPWdpZ4qFR07YSLJplgNeBoCYVOl0KHoEk8B5aIL TBg4IKKUu5Kpc8TS4Xk8gQL+PPUDD7qnL3Ef415QakQHld6yYIBNoku1cRZZP/ICUpRQGJqN 3jQMYhAFhUOS4q1IjgfTzFh8YxjEc1uRN76ZXFDCDuGVAiq176xM8hXjGzeGh4vb4L//Bdrx Gd+QZbvvh4vBbGy1R++X0ecTqA2X9W5kKsPh5MqrHUAxFMTK7KpSLzQo03ZTGzJQ3G2pI+wr nih51xJnJbOU+0XRYLe4kHlgQ02mHs2HKLw3rhe9NaHGrpkLknswP3w0wfzezEYDDwsy9ilq 4HVbWZI0lHwcZAVK/n/01Pwipez/5yzyTvpY4/93m63mjP/f29tr3fv/L1Hmb5aN08QPihtg oZ+QUUxPXfDlmYMxTd5i5zXa4YtgydmaizgJc/hBdBXOQs1F44ofm08Szpi18ELTBmdG027R wN3AX3hyi5CMJ310nfLQW+Z0LdOeOi1Ty8FrGEcORotLUKA2vhXWbzK33cRJ+bhlN1sN+9Hj dl2MHc7qvojqLNitpzvyBtxnJl9fQn+FmDYkf0vG80Q3qOt/c/cLoUhCz0FM7xp+Rv7yNNc6 4R6GCeO4wxOs1t2tne3UenSRmteI6Zp36dGRwy1ZyI9O7tJePjOxT5XGt7eymBnTXm08y4E1 O5KHR8I7b95SEln+umQsdyrqu5kuG7F5W2v9KiSwCZe3ZDD53BJY1EF772//h1LeSBS/l8Ml C91KntfjrBnF72X6FjzfBctrE1dFHPhHZbDuy+8p5f1f97Bz8PLwrvtYs//b3mnO5f+ajfv8 3xcp+3kxpqmZad20kr6Kc+RNoSByPMaLS0Cxwx361Cp1AhillIOz0WkchwmPvFTeQpjSmyGZ naAKOm1K/HC0+CLSMAqC6Iqa//SXi1CwZ3QzyMhESel6eFcI9B19AzmjotNflFbabbUJ1pr1 63TTLa5h9CN5/EdvJHVdH7j59qNUaB8a4VZfakl9QKdRd/LLNDYwe2Tr/cvjHez9E2LfOdzN Q6Z51JW7oznwT4jO5nBvD7fRfmiOzsY5g0WYd7drnaP+Rbft6H2G8C7v75284vKuoI7vnMkz RBEz1x/66hPfdzm776paHpu+8zUEc7g7nvFF8qqtkFNM81q5ld9/93gH3z2iJzo5ODGUq3sI Hc/LVwx5ZTa6pNOVCOKbEU/PwfqRgtXsa1ujWG0ebv7B7R+9FP8hZcnff7BpctxVH+vOf1ut 2b//sNfcbtzHf1+ivMKNXXvq8Yxf1FXjNt1TNrosYI7A9ubWhx/plOyj0UsnE4fftKGzaTCY /bmA/KP75zxKY0SP48DPwrl6T0Y4xln3RTuP6q6uruzp5KxnRP336tJRTx7itmHrA21MP9a2 PmRXpD/mJ3xP6TyxixwS0CCZxBROfazPI+AjV8P8WOMkAYnZQY/fxlWCPD+K4bfU5+jdsz+P AU/2oWXvGMaWx4TLfXnf57ah8hZd+zO2MI5KY9zwY0V2EmnQmSUfwnfd05eDp2fHLw4G3ZOT viHP1PNj++8+lFs/5ueYSEedYi6hYmzJ0JKGMHSShFu1Ko1e/lfB2sgFtRk0UHwYIXo+/6if 3m65Y/pzB0E0QhfbH6fw9zSE1o76OyGbulyMedHMak2jBsfZ7W95Dmz/OX3xfbkv9+W+3Jf7 8qXK/wAISf2SAFAAAA== --------------060500020708090204040202 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------060500020708090204040202--