diff for duplicates of <4C3EB04A.90000@snapgear.com> diff --git a/a/1.txt b/N1/1.txt index e8dd12a..716427e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -42,7 +42,7 @@ Greg >>> printk(KERN_EMERG "\nCODE:"); >>> tp = ((unsigned char *) fp->pc) - 0x20; >>> for (sp = (unsigned long *) tp, i = 0; (i < 0x40); i += 4) { ->>> if ((i % 0x10) = 0) +>>> if ((i % 0x10) == 0) >>> - printk(KERN_EMERG "%08x: ", (int) (tp + i)); >>> + printk(KERN_EMERG "%p: ", tp + i); >>> printk("%08x ", (int) *sp++); @@ -51,7 +51,7 @@ Greg >>> @@ -332,7 +332,7 @@ void dump(struct pt_regs *fp) >>> tp = ((unsigned char *) fp) - 0x40; >>> for (sp = (unsigned long *) tp, i = 0; (i < 0xc0); i += 4) { ->>> if ((i % 0x10) = 0) +>>> if ((i % 0x10) == 0) >>> - printk(KERN_EMERG "%08x: ", (int) (tp + i)); >>> + printk(KERN_EMERG "%p: ", tp + i); >>> printk("%08x ", (int) *sp++); @@ -60,7 +60,7 @@ Greg >>> @@ -341,7 +341,7 @@ void dump(struct pt_regs *fp) >>> tp = (unsigned char *) (rdusp() - 0x10); >>> for (sp = (unsigned long *) tp, i = 0; (i < 0x80); i += 4) { ->>> if ((i % 0x10) = 0) +>>> if ((i % 0x10) == 0) >>> - printk(KERN_EMERG "%08x: ", (int) (tp + i)); >>> + printk(KERN_EMERG "%p: ", tp + i); >>> printk("%08x ", (int) *sp++); diff --git a/a/content_digest b/N1/content_digest index 0c6341c..3dc9f9b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,8 +2,8 @@ "ref\04C3E5672.4090606@snapgear.com\0" "ref\020100715064354.GA5555@albatros\0" "From\0Greg Ungerer <gerg@snapgear.com>\0" - "Subject\0Re: [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of\0" - "Date\0Thu, 15 Jul 2010 06:52:58 +0000\0" + "Subject\0Re: [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of pointers in printk()\0" + "Date\0Thu, 15 Jul 2010 16:52:58 +1000\0" "To\0Kulikov Vasiliy <segooon@gmail.com>\0" "Cc\0kernel-janitors@vger.kernel.org" Greg Ungerer <gerg@uclinux.org> @@ -58,7 +58,7 @@ ">>> \tprintk(KERN_EMERG \"\\nCODE:\");\n" ">>> \ttp = ((unsigned char *) fp->pc) - 0x20;\n" ">>> \tfor (sp = (unsigned long *) tp, i = 0; (i < 0x40); i += 4) {\n" - ">>> \t\tif ((i % 0x10) = 0)\n" + ">>> \t\tif ((i % 0x10) == 0)\n" ">>> -\t\t\tprintk(KERN_EMERG \"%08x: \", (int) (tp + i));\n" ">>> +\t\t\tprintk(KERN_EMERG \"%p: \", tp + i);\n" ">>> \t\tprintk(\"%08x \", (int) *sp++);\n" @@ -67,7 +67,7 @@ ">>> @@ -332,7 +332,7 @@ void dump(struct pt_regs *fp)\n" ">>> \ttp = ((unsigned char *) fp) - 0x40;\n" ">>> \tfor (sp = (unsigned long *) tp, i = 0; (i < 0xc0); i += 4) {\n" - ">>> \t\tif ((i % 0x10) = 0)\n" + ">>> \t\tif ((i % 0x10) == 0)\n" ">>> -\t\t\tprintk(KERN_EMERG \"%08x: \", (int) (tp + i));\n" ">>> +\t\t\tprintk(KERN_EMERG \"%p: \", tp + i);\n" ">>> \t\tprintk(\"%08x \", (int) *sp++);\n" @@ -76,7 +76,7 @@ ">>> @@ -341,7 +341,7 @@ void dump(struct pt_regs *fp)\n" ">>> \ttp = (unsigned char *) (rdusp() - 0x10);\n" ">>> \tfor (sp = (unsigned long *) tp, i = 0; (i < 0x80); i += 4) {\n" - ">>> \t\tif ((i % 0x10) = 0)\n" + ">>> \t\tif ((i % 0x10) == 0)\n" ">>> -\t\t\tprintk(KERN_EMERG \"%08x: \", (int) (tp + i));\n" ">>> +\t\t\tprintk(KERN_EMERG \"%p: \", tp + i);\n" ">>> \t\tprintk(\"%08x \", (int) *sp++);\n" @@ -99,4 +99,4 @@ "8 Gardner Close FAX: +61 7 3217 5323\n" Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com -bfc6eca472539e5c980ead3c22e7157a6990e2a3b94fb5931f071e97c20636c5 +8364b4045222ee06aa10165eba98c37193a6f2c0221fd2da2a6c31a31b0f0143
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.