From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH] nfnetlink_log: do not expose NFULNL_COPY_DISABLED to user-space
Date: Thu, 15 Jul 2010 11:30:06 +0200 [thread overview]
Message-ID: <4C3ED51E.3060907@trash.net> (raw)
In-Reply-To: <20100714114914.4622.56919.stgit@decadence>
Am 14.07.2010 13:49, schrieb Pablo Neira Ayuso:
> This patch moves NFULNL_COPY_PACKET definition from
> linux/netfilter/nfnetlink_log.h to net/netfilter/nfnetlink_log.h
> since this copy mode is only for internal use.
>
> I have also changed the value from 0x03 to 0xff. Thus, we avoid
> a gap from user-space that may confuse users if we add new
> copy modes in the future.
>
> This change was introduced in:
> http://www.spinics.net/lists/netfilter-devel/msg13535.html
>
> Since this change is not included in any stable Linux kernel,
> I think it's safe to make this change now. Anyway, this copy
> mode does not make any sense from user-space, so this patch
> should not break any existing setup.
>
Applied, thanks Pablo.
prev parent reply other threads:[~2010-07-15 9:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 11:49 [PATCH] nfnetlink_log: do not expose NFULNL_COPY_DISABLED to user-space Pablo Neira Ayuso
2010-07-15 9:30 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3ED51E.3060907@trash.net \
--to=kaber@trash.net \
--cc=eric.dumazet@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.