Hi Niko,

On 07/15/2010 09:37 AM, Nicola Mfb wrote:
> On Thu, Jul 15, 2010 at 4:30 PM, Denis Kenzior <denkenz@gmail.com> wrote:
>> Hi Niko,
>>
>> On 07/14/2010 09:03 PM, Nicola Mfb wrote:
>>> Hi!
>>> I tried SendTones with calypso during an active call but it failed (v0.22):
>>>
>>> ofonod[259]: DLC0: > AT\r
>>> ofonod[259]: DLC0: < \r\nOK\r\n
>>> ofonod[259]: DLC0: Finally woke up the modem
>>> ofonod[259]: DLC0: > AT+VTS="1"\r
>>> ofonod[259]: DLC0: < \r\nERROR\r\n
>>> ofonod[259]: src/voicecall.c:generic_callback() command failed with
>>> error: Unknown error type
>>>
>>> Am I missing somethings?
>>>
>>
>> I admit I never tested it on the calypso.  I have a hunch that the
>> quotes are not needed for the DTMF character.  E.g. AT+VTS=1.
>>
>> Can you try the attached patch and report back?
> 
> What fine timing! I just was going to report that rebuilding ofono
> without the quotes on the tone char fixed the issue ;)

Good :) I pushed the quote fix upstream.

Thanks,
Denis