From: Jens Axboe <axboe@kernel.dk>
To: Christof Schmitt <christof.schmitt@de.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/1] block: Apply segment size and boundary limits to integrity data
Date: Thu, 15 Jul 2010 09:53:24 -0600 [thread overview]
Message-ID: <4C3F2EF4.6020203@kernel.dk> (raw)
In-Reply-To: <20100715154547.485829000@de.ibm.com>
On 07/15/2010 09:34 AM, Christof Schmitt wrote:
> From: Christof Schmitt <christof.schmitt@de.ibm.com>
>
> Apply the conditions used in __blk_recalc_rq_segments also to
> integrity data: Adhere to the maximum segment size and the segment
> boundary set by the driver. Without this change, a driver would
> receive integrity data blocks that do not adhere to the limits set for
> the request queue.
Thanks. The level of duplication there is nasty, particularly for such
intricate code as this that has had bugs in the past in the core.
--
Jens Axboe
next prev parent reply other threads:[~2010-07-15 15:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 15:34 [patch 0/1] Apply segment size and segment boundary to integrity data Christof Schmitt
2010-07-15 15:34 ` [patch 1/1] block: Apply segment size and boundary limits " Christof Schmitt
2010-07-15 15:53 ` Jens Axboe [this message]
2010-07-15 16:03 ` [patch 0/1] Apply segment size and segment boundary " Martin K. Petersen
2010-07-15 16:14 ` Jens Axboe
2010-07-15 16:35 ` Martin K. Petersen
2010-07-15 16:40 ` Jens Axboe
2010-07-16 8:30 ` Christof Schmitt
2010-07-20 4:45 ` Martin K. Petersen
2010-07-20 9:28 ` Christof Schmitt
2010-07-21 4:20 ` Martin K. Petersen
2010-08-02 11:05 ` Christof Schmitt
2010-08-03 4:44 ` Martin K. Petersen
2010-08-11 8:07 ` Christof Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3F2EF4.6020203@kernel.dk \
--to=axboe@kernel.dk \
--cc=christof.schmitt@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.