From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/1] ocfs2: don't overwrite error codes in ocfs2_init_acl
Date: Thu, 15 Jul 2010 14:24:29 -0700 [thread overview]
Message-ID: <4C3F7C8D.1010604@oracle.com> (raw)
In-Reply-To: <4C3DD0A6.4050902@oracle.com>
Good catch.
On 07/14/2010 07:58 AM, Tao Ma wrote:
> Hi Tiger,
> Tiger Yang wrote:
>
>> Hi, all,
>>
>> Pawel(pzlist at mp.pl) reported a bug in ocfs2 acl. This patch fix this
>> issue.
>>
>> Thanks,
>> tiger
>>
> @@ -381,7 +381,11 @@ int ocfs2_init_acl(handle_t *handle,
>
> mode = inode->i_mode;
> ret = posix_acl_create_masq(clone,&mode);
> if (ret>= 0) {
> - ret = ocfs2_acl_set_mode(inode, di_bh, handle, mode);
> + ret2 = ocfs2_acl_set_mode(inode, di_bh, handle, mode);
> + if (ret2) {
> + mlog_errno(ret2);
> You need to set ret = ret2 here so that we can return the error value to the caller.
> + goto cleanup;
> + }
> if (ret> 0) {
> ret = ocfs2_set_acl(handle, inode,
> di_bh, ACL_TYPE_ACCESS,
>
> Regards,
> Tao
>
>
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel
>
next prev parent reply other threads:[~2010-07-15 21:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 10:11 [Ocfs2-devel] [PATCH 1/1] ocfs2: don't overwrite error codes in ocfs2_init_acl Tiger Yang
2010-07-14 14:58 ` Tao Ma
2010-07-15 21:24 ` Sunil Mushran [this message]
2010-07-14 20:24 ` Sunil Mushran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3F7C8D.1010604@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.