From: Jeff Garzik <jeff@garzik.org>
To: Joseph Kogut <joseph.kogut@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers: net: 8139cp: Fixed 28 style errors, and 119 warnings.
Date: Thu, 15 Jul 2010 20:57:19 -0400 [thread overview]
Message-ID: <4C3FAE6F.3020406@garzik.org> (raw)
In-Reply-To: <AANLkTikspw9LxFFsXJgWn30k2qCVu5zkOAq2FhWTpQvW@mail.gmail.com>
> -/* The following settings are log_2(bytes)-4: 0 == 16 bytes .. 6==1024, 7==end of packet. */
> -#define RX_FIFO_THRESH 5 /* Rx buffer level before first PCI xfer. */
> +/* The following settings are log_2(bytes)-4: 0 == 16 bytes .. 6 == 1024, 7 == end of packet. */
> +#define RX_FIFO_THRESH 5 /* Rx buffer level before first PCI xfer. */
useless noise
> - unsigned wol_enabled : 1; /* Is Wake-on-LAN enabled? */
> + unsigned wol_enabled:1; /* Is Wake-on-LAN enabled? */
not an improvement
> - if (wol->wolopts & WAKE_PHY) options |= LinkUp;
> - if (wol->wolopts & WAKE_MAGIC) options |= MagicPacket;
> + if (wol->wolopts & WAKE_PHY)
> + options |= LinkUp;
> + if (wol->wolopts & WAKE_MAGIC)
> + options |= MagicPacket;
ditto
> - if (wol->wolopts & WAKE_UCAST) options |= UWF;
> - if (wol->wolopts & WAKE_BCAST) options |= BWF;
> - if (wol->wolopts & WAKE_MCAST) options |= MWF;
> + if (wol->wolopts & WAKE_UCAST)
> + options |= UWF;
> + if (wol->wolopts & WAKE_BCAST)
> + options |= BWF;
> + if (wol->wolopts & WAKE_MCAST)
> + options |= MWF;
ditto
>
> - if (options & UWF) wol->wolopts |= WAKE_UCAST;
> - if (options & BWF) wol->wolopts |= WAKE_BCAST;
> - if (options & MWF) wol->wolopts |= WAKE_MCAST;
> + options = cpr8(Config5);
> + if (options & UWF)
> + wol->wolopts |= WAKE_UCAST;
> + if (options & BWF)
> + wol->wolopts |= WAKE_BCAST;
> + if (options & MWF)
> + wol->wolopts |= WAKE_MCAST;
ditto
next prev parent reply other threads:[~2010-07-16 0:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 22:36 [PATCH] Drivers: net: 8139cp: Fixed 28 style errors, and 119 warnings Joseph Kogut
2010-07-15 22:36 ` Joseph Kogut
2010-07-16 0:57 ` Jeff Garzik [this message]
2010-07-16 1:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3FAE6F.3020406@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=joseph.kogut@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.