From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <borislav.petkov@amd.com>
Cc: Michal Schmidt <mschmidt@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Herrmann3, Andreas" <Andreas.Herrmann3@amd.com>,
Shaohua Li <shaohua.li@intel.com>, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 1/2] x86: fix keeping track of AMD C1E
Date: Fri, 16 Jul 2010 09:02:32 -0700 [thread overview]
Message-ID: <4C408298.8060004@zytor.com> (raw)
In-Reply-To: <20100716072244.GA27954@aftab>
On 07/16/2010 12:22 AM, Borislav Petkov wrote:
>>
>> No, the difference between using a separate variable and the CPU feature
>> bit is that CPU feature bit is ANDed across all CPUs, whereas this
>> variable is set if it is set on *any* CPU.
>
> ... and that's ok because the MSR bits get set on all cores after BIOS
> turns on C1E. Let me verify this though.
>
Is there any reason for the OR behavior? Otherwise, it's just plain
wrong...
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2010-07-16 16:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 18:59 [PATCH 0/2] x86: AMD C1E fix and cleanup Michal Schmidt
2010-07-13 18:59 ` [PATCH 1/2] x86: fix keeping track of AMD C1E Michal Schmidt
2010-07-13 20:05 ` H. Peter Anvin
2010-07-13 20:32 ` Borislav Petkov
2010-07-14 16:07 ` Borislav Petkov
2010-07-14 21:22 ` Michal Schmidt
2010-07-14 21:31 ` Michal Schmidt
2010-07-15 16:57 ` Borislav Petkov
2010-07-16 4:25 ` H. Peter Anvin
2010-07-16 6:39 ` Borislav Petkov
2010-07-15 21:56 ` H. Peter Anvin
2010-07-16 7:22 ` Borislav Petkov
2010-07-16 16:02 ` H. Peter Anvin [this message]
2010-07-16 16:25 ` Borislav Petkov
2010-07-16 22:28 ` H. Peter Anvin
2010-07-17 10:21 ` Borislav Petkov
2010-07-22 15:02 ` Borislav Petkov
2010-07-18 16:22 ` Heinz Diehl
2010-07-18 18:17 ` Borislav Petkov
2010-07-19 19:34 ` Borislav Petkov
2010-07-20 15:14 ` Heinz Diehl
2010-09-08 20:29 ` Andreas Herrmann
2010-09-10 6:04 ` Heinz Diehl
2010-07-18 16:39 ` Heinz Diehl
2010-07-13 19:00 ` [PATCH 2/2] x86: remove c1e_mask Michal Schmidt
[not found] <909896077.345011279054483129.JavaMail.root@zmail02.collab.prod.int.phx2.redhat.com>
2010-07-13 21:01 ` [PATCH 1/2] x86: fix keeping track of AMD C1E Michal Schmidt
2010-07-14 1:36 ` john stultz
2010-07-18 14:48 ` Heinz Diehl
2010-07-18 16:24 ` Heinz Diehl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C408298.8060004@zytor.com \
--to=hpa@zytor.com \
--cc=Andreas.Herrmann3@amd.com \
--cc=borislav.petkov@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mschmidt@redhat.com \
--cc=shaohua.li@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.