Re: [Patch] USB hot-plugging support - usb branch

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1571 bytes --]

On 07/07/2010 01:06 AM, Aleš Nesrsta wrote:
> Hi,
>
> I little bit changed "hot-plugging" support added into "usb" branch by
> Vladimir - see included patch. For the first look it maybe works on
> UHCI, I did not test it on OHCI yet...
>
> Basic info to this patch:
>   

> 2.
> I am not using original comparing of "hub->speed[i]" and "speed" to
> detect connection status change (but I left the "hub" structure in code,
> it can be maybe useful in future). I am using built-in functions of
> OHCI/UHCI controllers (available via root hub port register) which
> should be more reliable and are more systematic and closed to
> specifications.
>
>   
I thought of this at first too but haven't found such register on UHCI
and so decided to do it the same way on all systems. Since you've found
the needed register on UHCI I agree with your approach.
> 3.
> There is missing handling of disconnected devices. For this we will need
> to know on which port which device is attached - it is currently not
> known
But it can be easily stored in usbdevice structure.
>  - and we need to know it "recursively" because devices can be
> connected indirectly via non-root hubs.
> On this part I probably will not work in near future (currently I have
> no simple and suitable idea how to do it).
>
> Regards
> Ales
>   
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]