All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] always relocate fdt into an lmb-allocated memory block
Date: Sat, 17 Jul 2010 23:17:25 -0400	[thread overview]
Message-ID: <4C427245.6090206@gmail.com> (raw)
In-Reply-To: <1274731825-10169-1-git-send-email-timur@freescale.com>

Hi Timur,

On 05/24/2010 04:10 PM, Timur Tabi wrote:
> The device tree (fdt) must always exist in within the bootmap (usually the
> first 16MB of RAM).  If it doesn't, then boot_relocate_fdt() will allocate an
> LMB region in the bootmap and copy the fdt into that region.  It will also
> increase the size of the fdt.
>
> If the fdt is already in the bootmap, then previously the memory was just
> reserved.  There was no contingency if the reservation failed, however.
>
> By always allocating an lmb region and copying/resizing the fdt into that
> region, the code is simplified and the memory region is always allocated
> properly.
>
> Also change the types of some variables to avoid some typecasts.
>
> Signed-off-by: Timur Tabi<timur@freescale.com>
                            ^
Need a space in your SOB line?

> ---
>   common/image.c |   83 +++++++++++++++++++-------------------------------------
>   1 files changed, 28 insertions(+), 55 deletions(-)

I assume this is a "live" patch, and replaces the patch with the subject 
"libfdt: make fdt_increase_size() available to	everyone".  It looks like 
a good improvement to me and nobody threw any stones at it, so...

Acked-by: Gerald Van Baren <vanbaren@cideas.com>

[snip]

Best regards,
gvb

  reply	other threads:[~2010-07-18  3:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-24 20:10 [U-Boot] [PATCH] always relocate fdt into an lmb-allocated memory block Timur Tabi
2010-07-18  3:17 ` Jerry Van Baren [this message]
2010-07-18  4:37   ` Tabi Timur-B04825
2010-08-02 15:43 ` Timur Tabi
2010-08-02 15:51   ` Kumar Gala
2010-08-02 20:57     ` Wolfgang Denk
2010-08-07 23:36       ` Wolfgang Denk
2010-08-20 19:12         ` Timur Tabi
2010-10-11 15:02           ` Timur Tabi
2010-10-18 15:57 ` Timur Tabi
2010-10-20  5:25 ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C427245.6090206@gmail.com \
    --to=gvb.uboot@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.