From: Jeff Garzik <jgarzik@pobox.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Jens Axboe <jaxboe@fusionio.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tejun Heo <tj@kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH[RFC] Quirk macbook pro 6,2 into ahci mode
Date: Sun, 18 Jul 2010 18:44:41 -0400 [thread overview]
Message-ID: <4C4383D9.3060705@pobox.com> (raw)
In-Reply-To: <20100718184243.GA4062@srcf.ucam.org>
On 07/18/2010 02:42 PM, Matthew Garrett wrote:
> On Sun, Jul 18, 2010 at 10:03:44AM -0600, Jens Axboe wrote:
>> Looking at the specs, I don't see what I am missing to make this
>> work for resume. I'm assuming that EFI did initialize some bits
>> that am missing when coming out of resume, but I don't know which
>> bits.
>
> There's no guarantee that the AHCI BAR is programmed by the firmware (it
> seems to be on the Macs, but won't be on most hardware). Is it getting
> reprogrammed on resume?
That's definitely the key question.
I would have quirked AHCI/piix hardware into AHCI mode long ago, if
firmwares defaulting to piix mode would actually program the PCI BAR
correctly.
Or, if the firmware had some way to safely allocate a bus memory range,
which we could ourselves program into the PCI BAR. Some non-PC
platforms can do that.
Jeff
next prev parent reply other threads:[~2010-07-18 22:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-18 16:03 [PATCH[RFC] Quirk macbook pro 6,2 into ahci mode Jens Axboe
2010-07-18 18:42 ` Matthew Garrett
2010-07-18 20:34 ` Jens Axboe
2010-07-18 21:32 ` Tino Keitel
2010-07-19 5:40 ` Tino Keitel
2010-07-19 15:49 ` Jens Axboe
2010-07-19 15:53 ` Tino Keitel
2010-07-19 15:55 ` Jens Axboe
2010-07-19 17:23 ` Mike Snitzer
2010-07-19 20:40 ` Jens Axboe
2010-07-18 22:44 ` Jeff Garzik [this message]
2010-07-19 0:25 ` Jens Axboe
2010-07-19 10:13 ` Tejun Heo
2010-07-19 15:58 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4383D9.3060705@pobox.com \
--to=jgarzik@pobox.com \
--cc=jaxboe@fusionio.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.