All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block migraton: check sectors before shift operation.
Date: Mon, 19 Jul 2010 11:23:10 +0200	[thread overview]
Message-ID: <4C44197E.2020102@redhat.com> (raw)
In-Reply-To: <1279514742-6941-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>

Am 19.07.2010 06:45, schrieb Yoshiaki Tamura:
> Commit d246673dcb9911218ff555bcdf28b250e38fa46c has expanded the types
> of block drive that can be initialized for block migration.  Although
> bdrv_getlength() may return < 0, current code shifts it without
> checking.  This makes block migration initialization invalid and
> results in abort() due to calling qemu_malloc() with 0 size at
> bdrv_set_dirty_tracking().  This patch checks the return value of
> bdrv_getlength() by masking with BDRV_SECTOR_MASK.
> 
> Signed-off-by: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>

I applied a similar patch by Shahar Havivi to the block branch a few
days ago.

Kevin

  reply	other threads:[~2010-07-19  9:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-19  4:45 [Qemu-devel] [PATCH] block migraton: check sectors before shift operation Yoshiaki Tamura
2010-07-19  9:23 ` Kevin Wolf [this message]
2010-07-19 11:22   ` Yoshiaki Tamura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C44197E.2020102@redhat.com \
    --to=kwolf@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tamura.yoshiaki@lab.ntt.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.