From: Chanwoo Choi <cw00.choi@samsung.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org,
Joonyoung Shim <jy0922.shim@samsung.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/2]ASoC: multi-component - Fix S5P compile error
Date: Mon, 19 Jul 2010 22:17:58 +0900 [thread overview]
Message-ID: <4C445086.3020507@samsung.com> (raw)
In-Reply-To: <20100719130439.GB7002@sirena.org.uk>
Mark Brown wrote:
> On Mon, Jul 19, 2010 at 09:45:49PM +0900, Chanwoo Choi wrote:
>> This patch fix compile error on using I2S and WM8994 common code.
>
> This looks to be two completely separate issues and should have been
> sent as two separate patches, especially this one:
>
Ok, I will do.
>> -#if defined(CONFIG_CPU_S3C2412) || defined(CONFIG_CPU_S3C2413)
>> +#if defined(CONFIG_CPU_S3C2412) || defined(CONFIG_CPU_S3C2413) \
>> + || defined(CONFIG_CPU_S5PV210)
>> #define S3C_IIS_V2_SUPPORTED
>
> This is implmenting support for a new CPU, not fixing compile errors,
> and so the commit message is very misleading.
Ok, I will modify the commit message.
Thank you,
Chanwoo Choi
prev parent reply other threads:[~2010-07-19 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 12:45 [PATCH 2/2]ASoC: multi-component - Fix S5P compile error Chanwoo Choi
2010-07-19 13:04 ` Mark Brown
2010-07-19 13:17 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C445086.3020507@samsung.com \
--to=cw00.choi@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jassisinghbrar@gmail.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.