diff for duplicates of <4C44CF17.3030408@opengridcomputing.com> diff --git a/a/1.txt b/N1/1.txt index c2020fc..12f2c7a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,11 +1,11 @@ -Acked-by: Steve Wise <swise@opengridcomputing.com> +Acked-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org> Dan Carpenter wrote: > Q_FREECNT() returns the number of spaces free. This should never > be a negative amount. Also the num_wrs is an unsigned int so it can > never be less than zero. > -> Signed-off-by: Dan Carpenter <error27@gmail.com> +> Signed-off-by: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > In v1: I changed num_wrs to a signed int. > @@ -18,7 +18,7 @@ Dan Carpenter wrote: > num_wrs = Q_FREECNT(qhp->wq.sq_rptr, qhp->wq.sq_wptr, > qhp->wq.sq_size_log2); > - if (num_wrs <= 0) { -> + if (num_wrs = 0) { +> + if (num_wrs == 0) { > spin_unlock_irqrestore(&qhp->lock, flag); > err = -ENOMEM; > goto out; @@ -27,12 +27,17 @@ Dan Carpenter wrote: > num_wrs = Q_FREECNT(qhp->wq.sq_rptr, qhp->wq.sq_wptr, > qhp->wq.sq_size_log2); > - if ((num_wrs) <= 0) { -> + if (num_wrs = 0) { +> + if (num_wrs == 0) { > spin_unlock_irqrestore(&qhp->lock, flag); > return -ENOMEM; > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in -> the body of a message to majordomo@vger.kernel.org +> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -> +> + +-- +To unsubscribe from this list: send the line "unsubscribe linux-rdma" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index ff62454..d10350c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,9 @@ "ref\020100717102900.GG17585@bicker\0" "ref\04C446509.3010400@opengridcomputing.com\0" "ref\020100719203014.GN17585@bicker\0" - "From\0Steve Wise <swise@opengridcomputing.com>\0" + "From\0Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>\0" "Subject\0Re: [patch v2] infiniband: cxgb3: clean up signed check\0" - "Date\0Mon, 19 Jul 2010 22:17:59 +0000\0" + "Date\0Mon, 19 Jul 2010 17:17:59 -0500\0" "To\0Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" "Cc\0Steve Wise <swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>" Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> @@ -14,14 +14,14 @@ " kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" "\00:1\0" "b\0" - "Acked-by: Steve Wise <swise@opengridcomputing.com>\n" + "Acked-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>\n" "\n" "Dan Carpenter wrote:\n" "> Q_FREECNT() returns the number of spaces free. This should never\n" "> be a negative amount. Also the num_wrs is an unsigned int so it can\n" "> never be less than zero.\n" ">\n" - "> Signed-off-by: Dan Carpenter <error27@gmail.com>\n" + "> Signed-off-by: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\n" "> ---\n" "> In v1: I changed num_wrs to a signed int.\n" ">\n" @@ -34,7 +34,7 @@ "> \tnum_wrs = Q_FREECNT(qhp->wq.sq_rptr, qhp->wq.sq_wptr,\n" "> \t\t qhp->wq.sq_size_log2);\n" "> -\tif (num_wrs <= 0) {\n" - "> +\tif (num_wrs = 0) {\n" + "> +\tif (num_wrs == 0) {\n" "> \t\tspin_unlock_irqrestore(&qhp->lock, flag);\n" "> \t\terr = -ENOMEM;\n" "> \t\tgoto out;\n" @@ -43,14 +43,19 @@ "> \tnum_wrs = Q_FREECNT(qhp->wq.sq_rptr, qhp->wq.sq_wptr,\n" "> \t\t\t qhp->wq.sq_size_log2);\n" "> -\tif ((num_wrs) <= 0) {\n" - "> +\tif (num_wrs = 0) {\n" + "> +\tif (num_wrs == 0) {\n" "> \t\tspin_unlock_irqrestore(&qhp->lock, flag);\n" "> \t\treturn -ENOMEM;\n" "> \t}\n" "> --\n" "> To unsubscribe from this list: send the line \"unsubscribe linux-rdma\" in\n" - "> the body of a message to majordomo@vger.kernel.org\n" + "> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" "> More majordomo info at http://vger.kernel.org/majordomo-info.html\n" - > + "> \n" + "\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-rdma\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -5e1de3af736ed3ab651b8047eb92edac75b432ad27d16fe3194f93ae936797a2 +55723803232ee3eb24b7495b41b317725b2e64ff38a9365e5f3d32df248c113e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.