From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1ObCl7-0006F3-7X for mharc-grub-devel@gnu.org; Tue, 20 Jul 2010 09:21:21 -0400 Received: from [140.186.70.92] (port=57412 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObCkz-0006Er-Jj for grub-devel@gnu.org; Tue, 20 Jul 2010 09:21:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObCkx-0002z1-29 for grub-devel@gnu.org; Tue, 20 Jul 2010 09:21:13 -0400 Received: from mail-bw0-f41.google.com ([209.85.214.41]:55786) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObCkw-0002yi-Oc for grub-devel@gnu.org; Tue, 20 Jul 2010 09:21:11 -0400 Received: by bwz9 with SMTP id 9so3647113bwz.0 for ; Tue, 20 Jul 2010 06:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type; bh=4JilUZ3r/gAMxOKKqatkaKYPumAe6eLZtVJlvDBdLEA=; b=wt2Hs470zOn1cgZHpy9m0t0lsdVPIU+XhAjPXB87CvceR4kHXk08848S6Bohqfk9+v xRzIxmaGnWG8IFKK6S0FXOhD1khuy1Ot7uoFmQoUsznbpRQNdH4uonsG/aevTkNjBXXS JjQczAq5BilPSTYkzLGuSDDGUsSWr33xXJsqo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type; b=n7CJWIz6Ifvg74ah2wbb29RS3hHwkFDf9qrKlU4uX7lboMXEUs9InAR5tOMotdIyDy OQ4PPIHCTtIg9mYFHLKzH6PmI+wzVvkptCjyWe2XrpyJ2mz/XkD11ex+woV+FRsIryFX +uOUx5d1PQGUeqRkBiwqRUbMtStPTF69sdmOg= Received: by 10.204.34.17 with SMTP id j17mr4824910bkd.204.1279632069171; Tue, 20 Jul 2010 06:21:09 -0700 (PDT) Received: from debian.bg45.phnet ([81.62.128.73]) by mx.google.com with ESMTPS id y2sm28066144bkx.8.2010.07.20.06.21.07 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 20 Jul 2010 06:21:08 -0700 (PDT) Message-ID: <4C45A2BB.7040303@gmail.com> Date: Tue, 20 Jul 2010 15:20:59 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100620 Icedove/3.0.5 MIME-Version: 1.0 To: The development of GNU GRUB References: In-Reply-To: X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig5EE7D0771A358D27D9350928" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: Erik van der Kouwe , Fam Zheng Subject: Re: Minix 3 subpartition/filesystem patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2010 13:21:20 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5EE7D0771A358D27D9350928 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/19/2010 06:39 AM, Fam Zheng wrote: > Hi all, > > As a project of GSoC of MINIX community, we have almost completed the > work making MINIX 3 Multiboot compliant. I believe it would be very > helpful for us if GRUB can handle MINIX 3's subpartition and > filesystem correctly in the future, so I've made a patch for reading > the currently in use MINIX subpartition, so as to make GRUB Multiboot > access the OS kernel image. This patch has already been used for a > while in our development, to load and test MINIX kernel, and I think > now it's ready to be submitted here. > Why not multiboot2? It supplies a structure which is easier to copy and move around. If you need any multiboot2 amendment please contact. > There are two parts of the patch. First part is on fs/minix.c which is > changed to support the latest MINIX FS version 3 (previously only > version 2 is supported). The other part is on partmap/msdos.c, the > changes are made for the following reason: > Please don't mix 2 patches. Patch for subpartitions is copyright-insignificant so can go directly in. Minix3fs on the other hand would need some papers. > AFAIK there are two kinds of subpartition, one is from BSD, the other > is MINIX. With the latest trunk source, the subpartition is found by > GRUB, partition names like (hd0,msdos1,msdos1) can be recognized, but > the problem is the 'start' of partition: in the partition table for > MINIX subpartitions (the table found at the end of the first sector of > (hd0,msdos1) in this example), the field "start" is treated as an > relative value, where for MINIX it is actually an absolute one. Common brain damage. NetBSD has the same. + if(disk->partition && e->type =3D=3D GRUB_PC_PARTITION_TYPE_LINUX_MINIX) + p.start -=3D disk->partition->start; The criteria is probably wrong unless minix subpartition label mixes relative and absolute offset. Instead of this you have to check that container is msdos itself and that its type is minix. We'll need a similar check in bsdlabel too. We use gnu and not bsd indentation. Please adjust your patches. Patch for minix3 fs breaks any other version of minixfs. E.g. - grub_uint16_t inode_cnt; + grub_uint32_t inode_cnt; offsets all other fields. minix.mod must be split into 3 modules: minix1.mod, minix2.mod and minix3.mod with mostly shared source code. Look at ufs/ufs2 and afs/befs/afs_be/befs_be for how to do it. > > To solve this inconsistency, I patched partmap/msdos.c to convert the > value stored on harddisk to relative simply by a subtraction, this > happens only when a MINIX type (type field =3D=3D 0x81) subpartition is= > encountered. > > Thank you. > > --=20 > Best Regards! > Fam Zheng > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig5EE7D0771A358D27D9350928 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkxForsACgkQNak7dOguQgl2gwD/fSZynWvltDzGLtuB+gOPEzXA EBjKZbbHVjAqDZRIzq0A/1Zy+ozjqa1Qhi908r9pfrLclHpM+X6cgjds9+DW+0MR =2Vif -----END PGP SIGNATURE----- --------------enig5EE7D0771A358D27D9350928--