From: Stefan Kisdaroczi <kisda@domain.hid>
To: xenomai@xenomai.org
Subject: [Xenomai-help] [PATCH] x86: add Intel ICH10_1 to rthal_smi_pci_tbl
Date: Tue, 20 Jul 2010 15:41:54 +0200 [thread overview]
Message-ID: <4C45A7A2.3080401@domain.hid> (raw)
In-Reply-To: <4C3B1149.90309@domain.hid>
[-- Attachment #1.1: Type: text/plain, Size: 1650 bytes --]
patch attached.
On 12.07.2010 14:57, Theo Veenker wrote:
> Jan Kiszka wrote:
>
>> Theo Veenker wrote:
>>
>>> Hi,
>>>
>>> About a year ago when installing Xenomai on a new box it appeared this
>>> particular system required an addition to the PDI IDs table in arch/x86/smi.c.
>>> See this thread: https://mail.gna.org/public/xenomai-help/2009-08/msg00031.html
>>> Gilles said he would make the change to smi.c. That was with 2.4.8.
>>>
>>> Now I'm trying 2.5.3 but again the same PCI ID is missing. Is there a
>>> particular reason not to include this ID? On this system the SMI detection
>>> stuff doesn't work without it.
>>>
>>> It requires adding this line to rthal_smi_pci_tbl[]:
>>> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10_1)},
>>>
>> Does the SMI disabling actually work, ie. do you _measure_ any
>> difference? I'm asking as I think to remember that recent (but older
>> than ICH10) Intel chipset no longer provide the required interface or at
>> least changed it in an incompatible way.
>>
> Yes it does. First I got high latencies (~1800us). Then I remembered that I had to
> disable SMI on this platform, so I recompiled with SMI disabled, to find out it
> didn't make a difference. In the messages log I saw it didn't say anything about
> SMI so I looked into it and found out the PCI ID I had in before was gone. I added
> it and now the SMI workaround works and the high latencies are gone.
>
> Theo
>
> _______________________________________________
> Xenomai-help mailing list
> Xenomai-help@domain.hid
> https://mail.gna.org/listinfo/xenomai-help
>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-x86-add-Intel-ICH10_1-to-rthal_smi_pci_tbl.patch --]
[-- Type: text/x-patch; name="0001-x86-add-Intel-ICH10_1-to-rthal_smi_pci_tbl.patch", Size: 816 bytes --]
From 79a579bdd8c79d4160733f046b0bc89a9c3ff283 Mon Sep 17 00:00:00 2001
From: Stefan Kisdaroczi <kisda@domain.hid>
Date: Mon, 19 Jul 2010 10:45:45 +0200
Subject: [PATCH] x86: add Intel ICH10_1 to rthal_smi_pci_tbl
---
ksrc/arch/x86/smi.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/ksrc/arch/x86/smi.c b/ksrc/arch/x86/smi.c
index 2116899..93b5585 100644
--- a/ksrc/arch/x86/smi.c
+++ b/ksrc/arch/x86/smi.c
@@ -49,6 +49,7 @@ static struct pci_device_id rthal_smi_pci_tbl[] = {
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_0)},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_1)},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH8_4)},
+ {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10_1)},
{0,},
};
--
1.7.1
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2010-07-20 13:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 12:16 [Xenomai-help] PCI id missing from arch/x86/smi.c Theo Veenker
2010-07-12 12:35 ` Gilles Chanteperdrix
2010-07-12 12:39 ` Jan Kiszka
2010-07-12 12:57 ` Theo Veenker
2010-07-20 13:41 ` Stefan Kisdaroczi [this message]
2010-08-01 13:40 ` [Xenomai-help] [PATCH] x86: add Intel ICH10_1 to rthal_smi_pci_tbl Gilles Chanteperdrix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C45A7A2.3080401@domain.hid \
--to=kisda@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.