From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [Patch] strip disk->name of partition suffix in grub_disk_open
Date: Tue, 20 Jul 2010 15:52:33 +0200 [thread overview]
Message-ID: <4C45AA21.1090308@gmail.com> (raw)
In-Reply-To: <4C375B25.7060306@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
On 07/09/2010 07:23 PM, Grégoire Sutre wrote:
> Hi,
>
> When the argument passed to grub_disk_open is a string containing a
> partition, e.g. "hd0,msdos3,bsd7", disk->name is set to the full
> string instead of just the prefix up to the first ',' (here "hd0").
> This leads to incorrect partition identifiers when the disk name and
> the partition name are concatenated (I observed this in the debug
> messages of my nested partitions patch).
Which functions concatenate disk->name with anything else? It looks like
disk->name is with partitions by design.
>
> The attached patch fixes this issue.
>
> Grégoire
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2010-07-20 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 17:23 [Patch] strip disk->name of partition suffix in grub_disk_open Grégoire Sutre
2010-07-20 13:52 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2010-07-21 0:12 ` Grégoire Sutre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C45AA21.1090308@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.