From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1ObIGu-0001qB-JV for mharc-grub-devel@gnu.org; Tue, 20 Jul 2010 15:14:32 -0400 Received: from [140.186.70.92] (port=38920 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObIGr-0001pz-8X for grub-devel@gnu.org; Tue, 20 Jul 2010 15:14:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObIGq-0006MD-2T for grub-devel@gnu.org; Tue, 20 Jul 2010 15:14:29 -0400 Received: from mail-fx0-f41.google.com ([209.85.161.41]:51624) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObIGp-0006M8-US for grub-devel@gnu.org; Tue, 20 Jul 2010 15:14:28 -0400 Received: by fxm20 with SMTP id 20so3464845fxm.0 for ; Tue, 20 Jul 2010 12:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=jm+SVytNeauS7vJnAlskrXrM6qSim+a5p53RLAV2Ams=; b=vr14mcwMPMmfLnOWesxphMqbq5rv2oKLS04OXkQh/iS1ufGY7YmuR0jIWbEhLJnN1H gidzisqyo/NU5XzCf31hZ7OttWxT7MMqBRYrMaszZk/bL8Ona6Bpd31n9hEG7rKd5IpR WjCxUPYwzomZw/WnE9rUG1gLdL7yI0HZYlNNY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=oAobqNPARJjHyMfqomRLwIAF4CRrQcvIHZ2q//leF//7Qnb8QPsGo0H9V2RhvvVu7f sdKuOGXPPqLX+CQdhPZQ7fu534fBc1CU4PWGZvwMtPMin2M5ipjwyMkTMzkuQFVax5fb 4jUJS/1NSv/zJk5FIdR9sTP5B704XkSFu5PFk= Received: by 10.223.120.82 with SMTP id c18mr5831034far.69.1279653267134; Tue, 20 Jul 2010 12:14:27 -0700 (PDT) Received: from debian.bg45.phnet (vpn-global-dhcp3-221.ethz.ch [129.132.210.221]) by mx.google.com with ESMTPS id e16sm2564297fak.18.2010.07.20.12.14.26 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 20 Jul 2010 12:14:26 -0700 (PDT) Message-ID: <4C45E5B9.8050802@gmail.com> Date: Tue, 20 Jul 2010 20:06:49 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100620 Icedove/3.0.5 MIME-Version: 1.0 To: grub-devel@gnu.org References: <20100720162616.GS21862@riva.ucam.org> In-Reply-To: <20100720162616.GS21862@riva.ucam.org> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig8419E00FF69451BA3BD6280A" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Disable EFI cursor when switching to another terminal output X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2010 19:14:30 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8419E00FF69451BA3BD6280A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/20/2010 06:26 PM, Colin Watson wrote: > On my test hardware, the EFI cursor stays up when switching to gfxterm,= > which looks pretty odd. We should disable it when the EFI console stop= s > being active. > > 2010-07-20 Colin Watson > > Disable EFI cursor when the EFI console becomes inactive. > > * term/efi/console.c (grub_efi_console_init): New function. > (grub_efi_console_fini): New function. > (grub_console_term_output): Register init and fini methods. > > =20 Go ahead > =3D=3D=3D modified file 'term/efi/console.c' > --- term/efi/console.c 2010-05-09 11:20:35 +0000 > +++ term/efi/console.c 2010-07-20 15:35:42 +0000 > @@ -311,6 +311,20 @@ grub_console_setcursor (struct grub_term > efi_call_2 (o->enable_cursor, o, on); > } > =20 > +static grub_err_t > +grub_efi_console_init (struct grub_term_output *term) > +{ > + grub_console_setcursor (term, 1); > + return 0; > +} > + > +static grub_err_t > +grub_efi_console_fini (struct grub_term_output *term) > +{ > + grub_console_setcursor (term, 0); > + return 0; > +} > + > static struct grub_term_input grub_console_term_input =3D > { > .name =3D "console", > @@ -321,6 +335,8 @@ static struct grub_term_input grub_conso > static struct grub_term_output grub_console_term_output =3D > { > .name =3D "console", > + .init =3D grub_efi_console_init, > + .fini =3D grub_efi_console_fini, > .putchar =3D grub_console_putchar, > .getwh =3D grub_console_getwh, > .getxy =3D grub_console_getxy, > > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig8419E00FF69451BA3BD6280A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkxF5bkACgkQNak7dOguQglpeQEApnhFG7nIRF0ioZqwikJ66uBR d4E0H+COGYbHVJNoUdkA/RvkOAZ4/xBF+nQsYlrro6hB4zrd0o0b376rg+1Yj0fR =lA9h -----END PGP SIGNATURE----- --------------enig8419E00FF69451BA3BD6280A--