From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1ObMv3-0003CI-My for mharc-grub-devel@gnu.org; Tue, 20 Jul 2010 20:12:17 -0400 Received: from [140.186.70.92] (port=44689 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObMv1-0003Ar-CA for grub-devel@gnu.org; Tue, 20 Jul 2010 20:12:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObMv0-0003hn-8E for grub-devel@gnu.org; Tue, 20 Jul 2010 20:12:15 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:39772) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObMv0-0003hQ-3b for grub-devel@gnu.org; Tue, 20 Jul 2010 20:12:14 -0400 Received: by wwb13 with SMTP id 13so654763wwb.30 for ; Tue, 20 Jul 2010 17:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=1qnDd+WL7FH2jtwSWidjj4V9bXKMwuOauD0nigR5hdk=; b=Z4TWvzhGj6VAREtuca4SaJxMMGchcDTmyXdlyvnzIvSJ8zspQr3gDgqSYiQj6uSUtp z3pC7/NUXLCjoIe7uSu+qtgAfqyFZvlZO6ORmm4TEFLaph7fBknI1JpwYrNfs8M3mUT6 j1Bgve/Hiq995i+/dvStH2izf4Kf95kI6Mq5g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=ss+pMr6No/BMRC9ARn8sZ8IY7YqkOnnpS/D+NwrpSdWa3Bg4Tb2gtVgs0rd1rx/fAZ WIC/MoY0gKrr1XzhcY91TjmcFNbNHDmRclIgy4xBdu9TdQjMp5K/LRUanw2elUXltyLn 8xsXmYiaeWLZUaRJT2eARaQOq0BFbYWG1MzNw= Received: by 10.216.233.234 with SMTP id p84mr5924531weq.38.1279671132329; Tue, 20 Jul 2010 17:12:12 -0700 (PDT) Received: from [192.168.1.50] (c2433-1-88-160-112-182.fbx.proxad.net [88.160.112.182]) by mx.google.com with ESMTPS id v11sm3120386weq.16.2010.07.20.17.12.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 20 Jul 2010 17:12:11 -0700 (PDT) Message-ID: <4C463B5A.2030108@gmail.com> Date: Wed, 21 Jul 2010 02:12:10 +0200 From: =?UTF-8?B?R3LDqWdvaXJlIFN1dHJl?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100620 Icedove/3.0.5 MIME-Version: 1.0 To: The development of GNU GRUB References: <4C375B25.7060306@gmail.com> <4C45AA21.1090308@gmail.com> In-Reply-To: <4C45AA21.1090308@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [Patch] strip disk->name of partition suffix in grub_disk_open X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jul 2010 00:12:16 -0000 On 07/20/2010 03:52 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Which functions concatenate disk->name with anything else? It looks like > disk->name is with partitions by design. In several places, the (full) grub partition name is obtained by concatenating disk->name with the result of grub_partition_get_name. If I read the code correctly, this is what is done in: function iterate_partition, file normal/completion.c. function grub_device_iterate, file kern/device.c function grub_efidisk_get_device_name, file disk/efi/efidisk.c and I did the same in function grub_util_biosdisk_get_grub_dev, file kern/emu/hostdisk.c and more recently, for warnings/dprintfs, in function grub_partition_check_containment, file kern/partition.c function bsdlabel_partition_map_iterate, file partmap/bsdlabel.c Assuming that the above are correct and that disk->name is correctly set in grub_disk_open (e.g. hd0,msdos3,bsd7), then shouldn't disk->partition have a NULL parent (which is not the case right now)? Grégoire