From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Subject: Re: [PATCH v3 1/7] ARM: S5PV210: Add a Kconfig entry "S5PC110_EVT0_WORKAROUND" Date: Wed, 21 Jul 2010 12:47:03 +0100 Message-ID: <4C46DE37.5060105@simtec.co.uk> References: <1279517483-22751-1-git-send-email-myungjoo.ham@samsung.com> <1279517483-22751-2-git-send-email-myungjoo.ham@samsung.com> <4C464127.5040405@simtec.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from hull.simtec.co.uk ([78.105.113.97]:54680 "EHLO preston.local.simtec.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753591Ab0GULrZ (ORCPT ); Wed, 21 Jul 2010 07:47:25 -0400 In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: MyungJoo Ham Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kyungmin.park@samsung.com, kgene.kim@samsung.com, ben-linux@fluff.org On 21/07/10 02:13, MyungJoo Ham wrote: > On Wed, Jul 21, 2010 at 9:36 AM, Ben Dooks wrote: >> On 07/19/10 06:31, MyungJoo Ham wrote: >>> >>> Early S5PC110 (EVT0) chip had some issues required workaround from a >>> kernel. We can add such workaround codes with this Kconfig entry. >>> >>> Signed-off-by: MyungJoo Ham >>> Signed-off-by: Kyungmin Park >>> --- >>> arch/arm/mach-s5pv210/Kconfig | 7 +++++++ >>> 1 files changed, 7 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig >>> index 631019a..18802e7 100644 >>> --- a/arch/arm/mach-s5pv210/Kconfig >>> +++ b/arch/arm/mach-s5pv210/Kconfig >>> @@ -101,4 +101,11 @@ config MACH_SMDKC110 >>> Machine support for Samsung SMDKC110 >>> S5PC110(MCP) is one of package option of S5PV210 >>> >>> +config S5PC110_EVT0_WORKAROUND >>> + bool "S5PC110 Early Chip Workaround (EVT0)" >>> + help >>> + Early S5PC110 (so called EVT0) has errata items that should be >>> + addressed; otherwise the kernel may panic or be locked up. >>> Enable >>> + this option to execute workaround instructions. >>> + >>> endif >> >> What happens for non EVT0, is the a performance issue or is it exclusive? >> > > This S5PC110_EVT0_WORKAROUND addresses issues (erratic behaviors, not > performance issues) of "EVT-0" revisions, which is exclusive for these > EVT-0 only. They do not apply to the later (EVT-1 and so on) chips. Ok, so does the fix work for just EVT0? Does it exclude supporting other EVT sillicon as well? -- Ben From mboxrd@z Thu Jan 1 00:00:00 1970 From: ben@simtec.co.uk (Ben Dooks) Date: Wed, 21 Jul 2010 12:47:03 +0100 Subject: [PATCH v3 1/7] ARM: S5PV210: Add a Kconfig entry "S5PC110_EVT0_WORKAROUND" In-Reply-To: References: <1279517483-22751-1-git-send-email-myungjoo.ham@samsung.com> <1279517483-22751-2-git-send-email-myungjoo.ham@samsung.com> <4C464127.5040405@simtec.co.uk> Message-ID: <4C46DE37.5060105@simtec.co.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 21/07/10 02:13, MyungJoo Ham wrote: > On Wed, Jul 21, 2010 at 9:36 AM, Ben Dooks wrote: >> On 07/19/10 06:31, MyungJoo Ham wrote: >>> >>> Early S5PC110 (EVT0) chip had some issues required workaround from a >>> kernel. We can add such workaround codes with this Kconfig entry. >>> >>> Signed-off-by: MyungJoo Ham >>> Signed-off-by: Kyungmin Park >>> --- >>> arch/arm/mach-s5pv210/Kconfig | 7 +++++++ >>> 1 files changed, 7 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig >>> index 631019a..18802e7 100644 >>> --- a/arch/arm/mach-s5pv210/Kconfig >>> +++ b/arch/arm/mach-s5pv210/Kconfig >>> @@ -101,4 +101,11 @@ config MACH_SMDKC110 >>> Machine support for Samsung SMDKC110 >>> S5PC110(MCP) is one of package option of S5PV210 >>> >>> +config S5PC110_EVT0_WORKAROUND >>> + bool "S5PC110 Early Chip Workaround (EVT0)" >>> + help >>> + Early S5PC110 (so called EVT0) has errata items that should be >>> + addressed; otherwise the kernel may panic or be locked up. >>> Enable >>> + this option to execute workaround instructions. >>> + >>> endif >> >> What happens for non EVT0, is the a performance issue or is it exclusive? >> > > This S5PC110_EVT0_WORKAROUND addresses issues (erratic behaviors, not > performance issues) of "EVT-0" revisions, which is exclusive for these > EVT-0 only. They do not apply to the later (EVT-1 and so on) chips. Ok, so does the fix work for just EVT0? Does it exclude supporting other EVT sillicon as well? -- Ben