From: Manuel Naranjo <manuel@aircable.net>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: BlueZ <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH][RFC] Fix SDP resolving segfault
Date: Wed, 21 Jul 2010 12:15:46 -0300 [thread overview]
Message-ID: <4C470F22.7040102@aircable.net> (raw)
In-Reply-To: <AANLkTikcy_R0SOhL52AD372_DTA3c2pUVEY85lh3ZEj3@mail.gmail.com>
Luiz,
>> I don't really understand the need for these changes, but admitedly the
>> function does have issues since it first checks for !ctxt->session and
>> then later for ctxt->session even though at that point it's already
>> guaranteed that ctxt->session is not NULL.
>>
> Yep, I suspect it is something else too, there doesn't seems to be a
> call to bt_cancel_discovery in the last trace sent to the list, but
> the check for ctxt->session there seems buggy, we should always remove
> the context doesn't matter if it is connected or not.
>
I think the problem is that the watch function is still registered even
though we no longer have a session... maybe this doesn't make sense, no
way we have a context and don't have a session.
Still if there's no session the context never gets released.
> @Manuel: Does valgrind give you a nice bracktrace when it bluetoothd segfaults?
>
> Normally I use something like this:
>
>
>> sudo valgrind --trace-children=yes ./bluetoothd -dn
>>
Check the other email, I made it by running bluetoothd -ndt (this is a
feature I commited, which uses instrumentation-functions from gcc, a
really nice feature).
Manuel
next prev parent reply other threads:[~2010-07-21 15:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 23:33 [PATCH][RFC] Fix SDP resolving segfault Manuel Naranjo
2010-07-21 10:19 ` Johan Hedberg
2010-07-21 13:26 ` Luiz Augusto von Dentz
2010-07-21 15:15 ` Manuel Naranjo [this message]
2010-07-21 15:11 ` Manuel Naranjo
2010-07-23 20:37 ` Luiz Augusto von Dentz
2010-07-28 14:55 ` Luiz Augusto von Dentz
2010-07-28 16:17 ` Manuel Naranjo
2010-07-28 18:46 ` Manuel Naranjo
2010-07-29 8:53 ` Luiz Augusto von Dentz
2010-07-29 13:34 ` Manuel Naranjo
2010-08-03 13:21 ` Manuel Naranjo
2010-08-03 20:17 ` Luiz Augusto von Dentz
2010-08-03 20:24 ` Manuel Naranjo
2010-08-05 14:48 ` Manuel Naranjo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C470F22.7040102@aircable.net \
--to=manuel@aircable.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.