From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: de-BKLing blkfront Date: Wed, 21 Jul 2010 12:49:49 -0700 Message-ID: <4C474F5D.80204@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Daniel Stodden Cc: "Xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org When I was preparing the latest set of blkfront patches to send upstream to Jens Axboe, he pointed out there were conflicts with what he currently has queued. It turns out the conflict was from pushing the BKL (lock/unlock_kernel) into the open and release functions. I did the merge keeping them around all the new stuff you added to those functions, but I wonder if its actually necessary. Do we rely on open/release being globally serialized in there? I've pushed what I have into the upstream/blkfront branch in xen.git. Thanks, J