From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=54088 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObgKA-0008IH-PD for qemu-devel@nongnu.org; Wed, 21 Jul 2010 16:55:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObgK9-000434-IC for qemu-devel@nongnu.org; Wed, 21 Jul 2010 16:55:30 -0400 Received: from mail-iw0-f173.google.com ([209.85.214.173]:46301) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObgK9-00042s-Dq for qemu-devel@nongnu.org; Wed, 21 Jul 2010 16:55:29 -0400 Received: by iwn6 with SMTP id 6so605631iwn.4 for ; Wed, 21 Jul 2010 13:55:28 -0700 (PDT) Message-ID: <4C475EC0.2000805@codemonkey.ws> Date: Wed, 21 Jul 2010 15:55:28 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help References: <4C4704FC020000480009AB6E@sinclair.provo.novell.com> In-Reply-To: <4C4704FC020000480009AB6E@sinclair.provo.novell.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bruce Rogers Cc: qemu-devel@nongnu.org On 07/21/2010 03:32 PM, Bruce Rogers wrote: > Libvirt parses qemu help output to determine qemu features. In particular > it probes for the following: "cache=writethrough|writeback|none". The > addition of the unsafe cache mode was inserted within this string, as > opposed to being added to the end, which impacted libvirt's probe. > Unbreak libvirt by keeping the existing cache modes intact and add > unsafe to the end. > > This problem only manifests itself if a caching mode is explicitly > specified in the libvirt xml, in which case older syntax for caching is > passed to qemu, which it no longer understands. > > Signed-off-by: Bruce Rogers > Errr, libvirt is still doing this? This comes up frequently and it's a real PITA. Help text is not a feature probing interface. This is a libvirt bug and it needs to be fixed in libvirt. Regards, Anthony Liguori > --- > qemu-options.hx | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 0d7dd90..9ecc54e 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -118,7 +118,7 @@ ETEXI > DEF("drive", HAS_ARG, QEMU_OPTION_drive, > "-drive [file=file][,if=type][,bus=n][,unit=m][,media=d][,index=i]\n" > " [,cyls=c,heads=h,secs=s[,trans=t]][,snapshot=on|off]\n" > - " [,cache=writethrough|writeback|unsafe|none][,format=f]\n" > + " [,cache=writethrough|writeback|none|unsafe][,format=f]\n" > " [,serial=s][,addr=A][,id=name][,aio=threads|native]\n" > " [,readonly=on|off]\n" > " use 'file' as a drive image\n", QEMU_ARCH_ALL) >