From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [TRIVIAL] [PATCH] Remove unnecessary goto statements
Date: Thu, 22 Jul 2010 09:45:36 -0700 [thread overview]
Message-ID: <4C4875B0.2020404@oracle.com> (raw)
In-Reply-To: <AANLkTilVfUTA63SEMhnaagn-mmmEWwfKgogpYcJwdqxA@mail.gmail.com>
NAK. Sorry. I don't think the patch is worth it. It's not like
the compiler cannot detect this already.
On 07/22/2010 07:50 AM, Goldwyn Rodrigues wrote:
> Remove unnecessary goto statements.
> Signed-off-by: Goldwyn Rodrigues<rgoldwyn@suse.de>
>
> ---
> diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c
> index c30b644..c91527f 100644
> --- a/fs/ocfs2/suballoc.c
> +++ b/fs/ocfs2/suballoc.c
> @@ -824,10 +824,8 @@ int ocfs2_reserve_cluster_bitmap_bits(struct
> ocfs2_super *osb,
> ALLOC_NEW_GROUP);
> if (status< 0&& status != -ENOSPC) {
> mlog_errno(status);
> - goto bail;
> }
>
> -bail:
> return status;
> }
>
> @@ -1050,7 +1048,6 @@ static inline int
> ocfs2_block_group_set_bits(handle_t *handle,
> group_bh);
> if (status< 0) {
> mlog_errno(status);
> - goto bail;
> }
>
> bail:
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel
>
prev parent reply other threads:[~2010-07-22 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 14:50 [Ocfs2-devel] [TRIVIAL] [PATCH] Remove unnecessary goto statements Goldwyn Rodrigues
2010-07-22 15:22 ` Wengang Wang
2010-07-22 19:34 ` Goldwyn Rodrigues
2010-07-23 1:41 ` Wengang Wang
2010-07-22 16:45 ` Sunil Mushran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4875B0.2020404@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.