From: Daniel J Walsh <dwalsh@redhat.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: SELinux <selinux@tycho.nsa.gov>
Subject: Re: This is my first patch for systemd
Date: Thu, 22 Jul 2010 15:37:13 -0400 [thread overview]
Message-ID: <4C489DE9.7060905@redhat.com> (raw)
In-Reply-To: <1279817292.11197.44.camel@moss-pluto.epoch.ncsc.mil>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 07/22/2010 12:48 PM, Stephen Smalley wrote:
> On Thu, 2010-07-22 at 11:49 -0400, Daniel J Walsh wrote:
>> Updated with your comments. Strange the FIFO_FILE did not cause
>> security_compute_create to fail when passing a 0 for the tclass? I
>> though this should fail.
>>
>> I changed the patch to check the output of string_to_security_class.
>> Will write the selabel patch after this is accepted.
>>
>> Not checking the return of setfscreatecon(NULL) or
>> setsockcreatecon(NULL) Since I am not sure what to do if these fail and
>> not likely to fail since the previous calls worked.
>
> Yes, that's fine.
>
>> Is there any way to see what a socket is labeled? netstat -aZ is just
>> showing the process context, not the context of the label on the socket?
>
> netstat should be able to call fgetfilecon() on the socket fd after
> opening the /proc/pid/fd/<n> file to get the socket label. Not sure why
> it is using getpidcon() on the process instead. Who wrote that patch?
>
Probably me 8 years ago... :^(
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkxInekACgkQrlYvE4MpobPtBQCgyetTDlI5j2ZYp9uFItzJtZDR
4zAAoOrSPoHDYrdetSARtOWf3k2PjYgf
=n9Yp
-----END PGP SIGNATURE-----
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2010-07-22 19:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 12:22 This is my first patch for systemd Daniel J Walsh
2010-07-22 14:21 ` Stephen Smalley
2010-07-22 15:49 ` Daniel J Walsh
2010-07-22 16:48 ` Stephen Smalley
2010-07-22 19:37 ` Daniel J Walsh [this message]
2010-07-23 2:33 ` Kyle Moffett
2010-07-23 20:05 ` Stephen Smalley
2010-07-24 5:13 ` Kyle Moffett
2010-07-27 13:24 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C489DE9.7060905@redhat.com \
--to=dwalsh@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.