From: Jesse Larrew <jlarrew@linux.vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: print cores passed to firmware in decimal
Date: Thu, 22 Jul 2010 16:09:02 -0500 [thread overview]
Message-ID: <4C48B36E.6040505@linux.vnet.ibm.com> (raw)
In-Reply-To: <4553.1279775749@neuling.org>
On 07/22/2010 12:15 AM, Michael Neuling wrote:
> @@ -869,12 +895,12 @@ static void __init prom_send_capabilities(void)
> cores = (u32 *)PTRRELOC(&ibm_architecture_vec[IBM_ARCH_VEC_NRCORES_OFFSET]);
> if (*cores != NR_CPUS) {
> prom_printf("WARNING ! "
> - "ibm_architecture_vec structure inconsistent: 0x%x !\n",
> + "ibm_architecture_vec structure inconsistent: 0x%i !\n",
> *cores);
>
Since we're changing from hex to decimal, we shouldn't print the "0x".
Sincerely,
--
Jesse Larrew
Software Engineer, Linux on Power Kernel Team
IBM Linux Technology Center
Phone: (512) 973-2052 (T/L: 363-2052)
jlarrew@linux.vnet.ibm.com
next prev parent reply other threads:[~2010-07-22 21:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 5:15 [PATCH] powerpc: print cores passed to firmware in decimal Michael Neuling
2010-07-22 15:11 ` Segher Boessenkool
2010-07-22 23:15 ` Michael Neuling
2010-07-22 21:09 ` Jesse Larrew [this message]
2010-07-23 1:44 ` Michael Neuling
2010-07-28 1:24 ` [PATCH] powerpc: print decimal values in prom_init.c Michael Neuling
2010-07-28 4:26 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C48B36E.6040505@linux.vnet.ibm.com \
--to=jlarrew@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.