From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH V2] Fix the nested PR lock calling issue
Date: Fri, 23 Jul 2010 16:08:45 -0700 [thread overview]
Message-ID: <4C4A20FD.5080508@oracle.com> (raw)
In-Reply-To: <4C4A1AF2.7080700@oracle.com>
ok. Then review Jiaju's earlier patch.
On 07/23/2010 03:42 PM, Tiger Yang wrote:
> Hi, Sunil,
>
> I think put them in ocfs2_check_acl() is better.
> First, check mount option in ocfs2_check_acl() is more clear than in
> _ocfs2_get_acl().
> Second, we already have ocfs2_get_acl and ocfs2_get_acl_nolock, so it
> seems _ocfs2_get_acl is redundant and could cause confusing for
> reading the code.
>
> Regards,
> tiger
>
> On 07/21/2010 02:26 PM, Sunil Mushran wrote:
>> Why not add _ocfs2_get_acl() that does the same without
>> taking the cluster locks?
>
next prev parent reply other threads:[~2010-07-23 23:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 14:48 [Ocfs2-devel] [PATCH V2] Fix the nested PR lock calling issue Jiaju Zhang
2010-07-21 15:17 ` Wengang Wang
2010-07-21 16:05 ` Jiaju Zhang
2010-07-21 18:26 ` Sunil Mushran
2010-07-22 5:26 ` Jiaju Zhang
2010-07-22 10:11 ` Wengang Wang
2010-07-22 13:16 ` Jiaju Zhang
2010-07-22 13:27 ` Wengang Wang
2010-07-23 22:42 ` Tiger Yang
2010-07-23 23:08 ` Sunil Mushran [this message]
2010-07-26 3:26 ` Jiaju Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4A20FD.5080508@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.