All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Heinz Diehl <htd@fancy-poultry.org>
Cc: jmoyer@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cfq-iosched: don't allow aliased requests to starve  others
Date: Sat, 24 Jul 2010 12:03:01 +0200	[thread overview]
Message-ID: <4C4ABA55.2000204@kernel.dk> (raw)
In-Reply-To: <20100724080459.GA6500@fancy-poultry.org>

On 07/24/2010 10:04 AM, Heinz Diehl wrote:
> On 14.07.2010, Jeff Moyer wrote: 
> 
>> Comments, as always, are welcome.
> 
> This patch, applied to 2.6.35-rc6, increases desktop interactivity
> _NOTICEABLY_ on my quadcore machine, and the machine stays rock-stable.
> I have now tested this patch with the latest 2.6.35-rc kernels over 
> 1 week.
> 
> Unfortunately, I can't provide some testing results which makes this
> statement more objective, but I'll do some synthetic testing in the next
> days.

It is extremely unlikely that this patch will have any impact on
"normal" workloads. To even hit a code path where it would make a
difference, you would need to use O_DIRECT IO, otherwise you cannot have
aliases in the IO scheduler.

-- 
Jens Axboe


  reply	other threads:[~2010-07-24 10:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-14 15:09 [PATCH] cfq-iosched: don't allow aliased requests to starve others Jeff Moyer
2010-07-14 19:01 ` Jeff Moyer
2010-07-23  4:25 ` Vivek Goyal
2010-07-23 15:07   ` Jeff Moyer
2010-07-23 16:17     ` Vivek Goyal
2010-07-24  9:30     ` Jens Axboe
2010-07-24  8:04 ` Heinz Diehl
2010-07-24 10:03   ` Jens Axboe [this message]
2010-07-26 13:17     ` Jeff Moyer
2010-08-02 11:54       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C4ABA55.2000204@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=htd@fancy-poultry.org \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.