From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Bob Feretich <bob.feretich@domain.hid>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai-help] Adeos patch prevents IRQ 384 (MMC Chip Detect) on omap-2.6.33
Date: Sun, 25 Jul 2010 11:24:12 +0200 [thread overview]
Message-ID: <4C4C02BC.4010306@domain.hid> (raw)
In-Reply-To: <4C4BC6D6.8070806@domain.hid>
Bob Feretich wrote:
> Test 1 results:
> With the Adeos patch installed, but Adeos disabled, the system ran
> normally. IRQ 384s were presented and serviced. (The SD card removal
> amd insertion was handled correctly.)
Ok. Could you try the following patch? It fixes the "always growing PIH
interrupt count" number here, and now I have some twl4030_usb
interrupts. However, I could not test the SD card insertion/removal,
because I am working on the board remotely.
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 8d608a1..0037e31 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -478,10 +478,6 @@ static int omap_i2c_xfer_msg(struct i2c_adapter *adap,
if (msg->len == 0)
return -EINVAL;
-#ifdef CONFIG_IPIPE
- disable_irq(dev->irq);
-#endif /* CONFIG_IPIPE */
-
omap_i2c_write_reg(dev, OMAP_I2C_SA_REG, msg->addr);
/* REVISIT: Could the STB bit of I2C_CON be used with probing? */
@@ -525,9 +521,6 @@ static int omap_i2c_xfer_msg(struct i2c_adapter *adap,
/* Let the user know if i2c is in a bad state */
if (time_after(jiffies, delay)) {
-#ifdef CONFIG_IPIPE
- enable_irq(dev->irq);
-#endif /* CONFIG_IPIPE */
dev_err(dev->dev, "controller timed out "
"waiting for start condition to finish\n");
return -ETIMEDOUT;
@@ -539,9 +532,6 @@ static int omap_i2c_xfer_msg(struct i2c_adapter *adap,
w &= ~OMAP_I2C_CON_STT;
omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, w);
}
-#ifdef CONFIG_IPIPE
- enable_irq(dev->irq);
-#endif /* CONFIG_IPIPE */
/*
* REVISIT: We should abort the transfer on signals, but the bus goes
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 9df9a5a..fb4b9f2 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -332,7 +332,7 @@ static int twl4030_irq_thread(void *data)
note_interrupt(module_irq, d,
IRQ_NONE);
else
- d->handle_irq(module_irq, d);
+ ipipe_handle_irq_cond(module_irq);
}
}
local_irq_enable();
--
Gilles.
next prev parent reply other threads:[~2010-07-25 9:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 3:36 [Xenomai-help] Adeos patched kernel hangs mounting root file system Bob Feretich
2010-07-19 4:19 ` Gilles Chanteperdrix
2010-07-19 7:18 ` Bob Feretich
2010-07-19 8:31 ` Gilles Chanteperdrix
2010-07-20 0:11 ` Bob Feretich
2010-07-20 7:11 ` Gilles Chanteperdrix
2010-07-20 7:31 ` Bob Feretich
2010-07-20 7:45 ` Gilles Chanteperdrix
2010-07-20 16:29 ` Gilles Chanteperdrix
2010-07-20 20:20 ` Bob Feretich
2010-07-20 21:24 ` Gilles Chanteperdrix
2010-07-21 5:06 ` Bob Feretich
2010-07-21 5:24 ` Gilles Chanteperdrix
2010-07-21 6:19 ` Bob Feretich
2010-07-21 20:33 ` Bob Feretich
2010-07-21 23:30 ` Bob Feretich
2010-07-22 22:10 ` [Xenomai-help] Adeos patched kernel hangs mounting root file system - correction Bob Feretich
2010-07-22 22:14 ` Gilles Chanteperdrix
2010-07-22 23:33 ` Bob Feretich
2010-07-22 23:35 ` Gilles Chanteperdrix
2010-07-23 0:37 ` Bob Feretich
2010-07-23 5:37 ` Gilles Chanteperdrix
2010-07-23 23:43 ` [Xenomai-help] Adeos patch prevents IRQ 384 (MMC Chip Detect) on omap-2.6.33 Bob Feretich
2010-07-24 12:42 ` Gilles Chanteperdrix
2010-07-24 12:57 ` Gilles Chanteperdrix
2010-07-24 18:50 ` Bob Feretich
2010-07-24 18:57 ` Gilles Chanteperdrix
2010-07-25 5:08 ` Bob Feretich
2010-07-25 7:02 ` Gilles Chanteperdrix
2010-07-25 9:24 ` Gilles Chanteperdrix [this message]
2010-07-26 1:57 ` [Xenomai-help] Adeos patch prevents IRQ 384 (MMC Chip Detect) on omap-2.6.33 - working now Bob Feretich
2010-07-26 7:01 ` Gilles Chanteperdrix
2010-07-20 7:15 ` [Xenomai-help] Adeos patched kernel hangs mounting root file system Bob Feretich
2010-07-20 7:17 ` Gilles Chanteperdrix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4C02BC.4010306@domain.hid \
--to=gilles.chanteperdrix@xenomai.org \
--cc=bob.feretich@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.