All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Michael Jensen <emjay1988@gmail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: comedidev: Removed unused macro definitions
Date: Sun, 25 Jul 2010 17:27:19 +0200	[thread overview]
Message-ID: <4C4C57D7.8090804@gmail.com> (raw)
In-Reply-To: <1280070874-8961-1-git-send-email-emjay1988@gmail.com>

On 07/25/2010 05:14 PM, Michael Jensen wrote:
> Removed macro definition that wasn't used.
> 
> Signed-off-by: Michael Jensen <emjay1988@gmail.com>
> ---
>  drivers/staging/comedi/comedidev.h |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 4eb2b77..b225fff 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -61,11 +61,6 @@
>  	module_init(x ## _init_module);					\
>  	module_exit(x ## _cleanup_module);
>  
> -#define COMEDI_MODULE_MACROS						\
> -	MODULE_AUTHOR("Comedi http://www.comedi.org");		\
> -	MODULE_DESCRIPTION("Comedi low-level driver");			\
> -	MODULE_LICENSE("GPL");
> -
>  #define COMEDI_INITCLEANUP(x)						\
>  	COMEDI_MODULE_MACROS		\

As you are removing COMEDI_MODULE_MACROS, it makes sense to remove
COMEDI_INITCLEANUP too.

>  	COMEDI_INITCLEANUP_NOMODULE(x)


-- 
js

  reply	other threads:[~2010-07-25 15:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-25 15:14 [PATCH] Staging: comedi: comedidev: Removed unused macro definitions Michael Jensen
2010-07-25 15:27 ` Jiri Slaby [this message]
2010-07-26  1:11   ` Michael Jensen
2010-07-26 22:43 ` Greg KH
2010-07-26 23:46   ` Michael Jensen
2010-07-27  0:01     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C4C57D7.8090804@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=emjay1988@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.