From: "H. Peter Anvin" <hpa@zytor.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Javier Martinez Canillas <martinez.javier@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Jacob Pan <jacob.jun.pan@linux.intel.com>,
Feng Tang <feng.tang@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, mrst: remove unused mrst_identify_cpu()
Date: Sun, 25 Jul 2010 11:56:03 -0700 [thread overview]
Message-ID: <4C4C88C3.1050103@zytor.com> (raw)
In-Reply-To: <20100725115524.76138396@lxorguk.ukuu.org.uk>
On 07/25/2010 03:55 AM, Alan Cox wrote:
> On Sat, 24 Jul 2010 22:04:45 -0700
> "H. Peter Anvin" <hpa@zytor.com> wrote:
>
>> Jacob, is this obsolete or something that will be needed in future versions?
>>
>> It seems that either __mrst_cpu_chip should be killed off, or read-only
>> users should be using the inline instead of __mrst_cpu_chip directly.
>
> And how is the inline going to access the variable if the variable isn't
> global ...
>
> Alan
Well, of course it needs to be global. The "or" in the above sentence
is an xor.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2010-07-25 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-25 4:50 [PATCH] x86, mrst: remove unused mrst_identify_cpu() Javier Martinez Canillas
2010-07-25 5:04 ` H. Peter Anvin
2010-07-25 10:55 ` Alan Cox
2010-07-25 18:56 ` H. Peter Anvin [this message]
2010-07-25 10:54 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4C88C3.1050103@zytor.com \
--to=hpa@zytor.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=feng.tang@intel.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martinez.javier@gmail.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.