From: Yinghai Lu <yinghai@kernel.org>
To: Corey Minyard <minyard@acm.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthew Garrett <mjg@redhat.com>, Len Brown <len.brown@intel.com>,
Myron Stowe <myron.stowe@hp.com>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: Fix memleaking for add_smi when duplicating happen
Date: Mon, 26 Jul 2010 21:41:07 -0700 [thread overview]
Message-ID: <4C4E6363.7060705@kernel.org> (raw)
In-Reply-To: <4C4E3F03.4030707@acm.org>
On 07/26/2010 07:05 PM, Corey Minyard wrote:
> Please run this through checkpatch, as it has coding style violations.
yhlu@linux-siqj:~/xx/xx/kernel/tip/linux-2.6> ./scripts/checkpatch.pl patches/ipmi_reg_size.patch
total: 0 errors, 0 warnings, 105 lines checked
patches/ipmi_reg_size.patch has no obvious style problems and is ready for submission.
yhlu@linux-siqj:~/xx/xx/kernel/tip/linux-2.6>
>
> Also, this patch appears to fix bugs in addition to adding the print.
> Can we have a separate patch for that?
in the comment log, i already mentioned that.
will separate it to twol
>
> I'm also not clear on the reason for this. I believe all this
> information is already available in /proc/ipmi/<if#>/params. I don't
> think there is a strong reason to print it to the log.
then why there is printing for ACPI path and pci path?
Yinghai
next prev parent reply other threads:[~2010-07-27 4:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 1:25 [PATCH] ipmi: Fix memleaking for add_smi when duplicating happen Yinghai Lu
2010-07-27 2:05 ` Corey Minyard
2010-07-27 4:41 ` Yinghai Lu [this message]
2010-07-27 14:42 ` Corey Minyard
2010-07-27 4:57 ` [PATCH 1/2] " Yinghai Lu
2010-07-27 15:44 ` Myron Stowe
2010-07-27 4:58 ` [PATCH 2/2] ipmi: print info for spmi and smbios path like acpi and pci Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4E6363.7060705@kernel.org \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=mjg@redhat.com \
--cc=myron.stowe@hp.com \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.