All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Fehlig <jfehlig@novell.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] [xend] fix coredump-{restart, destroy} on_crash actions
Date: Tue, 27 Jul 2010 09:09:11 -0600	[thread overview]
Message-ID: <4C4EF697.8060506@novell.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

After all of these years, more fallout from xen-api and legacy xmlrpc
integration.  Can't say I'll miss xend :-).

Please apply to xen-4.0-testing.

Regards,
Jim



[-- Attachment #2: xend-crash-behavior.patch --]
[-- Type: text/x-patch, Size: 1270 bytes --]

# HG changeset patch
# User Jim Fehlig <jfehlig@novell.com>
# Date 1280165174 21600
# Node ID 3da5c666fb1ba1f532803e59040e7a0d8481c2ba
# Parent  ac7e4c6ec6c7494e4046da92aa8f62f6c1371438
The xm documentation and example config files state that possible
"on crash" behaviors include coredump-{restart,destroy},
but domain creation will fail if either of these options are
specified

xen52:~ # grep coredump /etc/xen/vm/test
on_crash="coredump-restart"
xen52:~ # xm create /etc/xen/vm/test
Using config file "/etc/xen/vm/test".
Error: Invalid argument.

coredump-and-{restart,destroy} are permissible but unnecessarily
verbose and inconsistent with documentation.  This patch simply
adds coredump-{restart,destroy} to the list of permissible values.

    Signed-off-by: Jim Fehlig <jfehlig@novell.com>

diff -r ac7e4c6ec6c7 -r 3da5c666fb1b tools/python/xen/xend/XendAPIConstants.py
--- a/tools/python/xen/xend/XendAPIConstants.py	Fri Jul 23 19:23:49 2010 +0100
+++ b/tools/python/xen/xend/XendAPIConstants.py	Mon Jul 26 11:26:14 2010 -0600
@@ -45,8 +45,10 @@
 XEN_API_ON_CRASH_BEHAVIOUR = [
     'destroy',
     'coredump_and_destroy',
+    'coredump_destroy',
     'restart',
     'coredump_and_restart',
+    'coredump_restart',
     'preserve',
     'rename_restart'
 ]

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2010-07-27 15:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27 15:09 Jim Fehlig [this message]
2010-07-27 15:11 ` [PATCH] [xend] fix coredump-{restart, destroy} on_crash actions Keir Fraser
2010-07-27 16:41 ` Ian Jackson
2010-07-27 17:59   ` Jim Fehlig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C4EF697.8060506@novell.com \
    --to=jfehlig@novell.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.