All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: "Roedel, Joerg" <Joerg.Roedel@amd.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] KVM: SVM: Emulate next_rip svm feature
Date: Wed, 28 Jul 2010 15:25:37 +0300	[thread overview]
Message-ID: <4C5021C1.6030000@redhat.com> (raw)
In-Reply-To: <20100728121822.GH26098@amd.com>

  On 07/28/2010 03:18 PM, Roedel, Joerg wrote:
>
>
>> The guest (L2 in this case) is doomed since it execution cannot
>> continue.  But L1 and L0 are fine.  The problem with L2 avoiding
>> intercepts is that L2 can change control registers and take over L1.
> Right too. We can not ignore it. The right fix is probably a check for
> the instruction intercepts right after the decoder has run and before
> the emulator ran.

Should be easy - just like we have the Priv flag, add a bitfield to 
opcode_table that says which bit we need to check in the control area.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


  reply	other threads:[~2010-07-28 12:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27 16:14 [PATCH 0/2] Nested SVM fix and next_rip emulation Joerg Roedel
2010-07-27 16:14 ` [PATCH 1/2] KVM: SVM: Sync efer back into nested vmcb Joerg Roedel
2010-07-27 19:07   ` Avi Kivity
2010-07-28  7:54     ` Roedel, Joerg
2010-07-27 16:14 ` [PATCH 2/2] KVM: SVM: Emulate next_rip svm feature Joerg Roedel
2010-07-27 18:32   ` Avi Kivity
2010-07-28  9:37     ` Roedel, Joerg
2010-07-28 10:28       ` Avi Kivity
2010-07-28 11:25         ` Roedel, Joerg
2010-07-28 11:34           ` Avi Kivity
2010-07-28 11:51             ` Roedel, Joerg
2010-07-28 11:57               ` Avi Kivity
2010-07-28 12:18                 ` Roedel, Joerg
2010-07-28 12:25                   ` Avi Kivity [this message]
2010-07-28 10:28 ` [PATCH 0/2] Nested SVM fix and next_rip emulation Avi Kivity
2010-07-28 16:53 ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C5021C1.6030000@redhat.com \
    --to=avi@redhat.com \
    --cc=Joerg.Roedel@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.