From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Oe7qF-0000qf-Oh for mharc-grub-devel@gnu.org; Wed, 28 Jul 2010 10:42:43 -0400 Received: from [140.186.70.92] (port=35829 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oe7qD-0000pB-9v for grub-devel@gnu.org; Wed, 28 Jul 2010 10:42:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oe7qB-0000TV-W6 for grub-devel@gnu.org; Wed, 28 Jul 2010 10:42:41 -0400 Received: from mail-fx0-f41.google.com ([209.85.161.41]:37566) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oe7qB-0000TJ-Qz for grub-devel@gnu.org; Wed, 28 Jul 2010 10:42:39 -0400 Received: by fxm20 with SMTP id 20so1408826fxm.0 for ; Wed, 28 Jul 2010 07:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=hbshNqy+8Xy9S3ujMrTpQ2SYRs7C8sHbIsDv+QMldQM=; b=stmiEniFY5otjejnVRn/cqUK3vP2SQ6smoVc50roiW1A/W487yYx4LnBDMAfDQ3Ids Ew0xv87RDe+9cyc0eV1YRu5DId7w7xG+v0QfI3yLneY0bNzGQ8s8rLhUyvQPasvpv/la O68pw7C1Jyhg1IhZte0vYXBLy+PkkiVk/s8Qc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=nnHEgdg5Iljkqf4FvoFR2sPh60KHqm71LalTcKYXNd35kvgfBKGmJbJK01SWJRos3+ 8oOltxloW19pekGo3kM/nQjF0+UnPnvHaVraSpkiFBA8pCFt8nRP8lvapCaNaBl6QR98 uMAbQy65ePFttivV5duRBYl1fB2osWCgjBuKk= Received: by 10.223.126.71 with SMTP id b7mr10004993fas.97.1280328159046; Wed, 28 Jul 2010 07:42:39 -0700 (PDT) Received: from debian.bg45.phnet (vpn-global-165-dhcp.ethz.ch [129.132.211.165]) by mx.google.com with ESMTPS id r8sm2603129faq.34.2010.07.28.07.42.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 28 Jul 2010 07:42:37 -0700 (PDT) Message-ID: <4C5041DC.1030908@gmail.com> Date: Wed, 28 Jul 2010 17:42:36 +0300 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100620 Icedove/3.0.5 MIME-Version: 1.0 To: grub-devel@gnu.org References: <20100725030948.GA25314@feather> In-Reply-To: <20100725030948.GA25314@feather> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigC7DB40A684EA7820ED73CF6B" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Add grub_dcprintf for continuations without file/line X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2010 14:42:42 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC7DB40A684EA7820ED73CF6B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/25/2010 06:09 AM, Josh Triplett wrote: > The attached patch adds a new variant of grub_dprintf, grub_dcprintf, > which avoids printing the __FILE__:__LINE__: prefix. This allows > printing a single line with multiple print statements; for instance: > > grub_dprintf("some_module", "Thingy: "); > print_complicated_thingy(thingy); > grub_dcprintf("some_module", ", more details here\n"); > > Without the dcprintf variant, this line will contain three different > file/line prefixes. > > I also added support for a "no-file-line" token in the debug environmen= t > variable, which turns off the file/line prefixes entirely. > > =20 core is very size sensitive. You need a valid usecase to justify such a feature in it. It feels like useful only for dumping a mass of info. In practice users can only report back around 4-5 lines, sometimes a compelete screen by taking its picture, so this info would be lost in bugreports anyway. If you're developping something you usually need a dump in that exact place only once and then using grub_printf is usually easier. > - Josh Triplett > =20 > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigC7DB40A684EA7820ED73CF6B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkxQQdwACgkQNak7dOguQgnEPAEAoQQUlW0jGQ++UcA1r9FMv3fL fK5yg5Ri1k+7nsKv4HsBAJQAHPVrFDWPg8we+qNLYRjXYPbur1khkTxyrY7IqYcz =pgo0 -----END PGP SIGNATURE----- --------------enigC7DB40A684EA7820ED73CF6B--