From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Oe8vO-0002Dk-DL for mharc-grub-devel@gnu.org; Wed, 28 Jul 2010 11:52:06 -0400 Received: from [140.186.70.92] (port=59889 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oe8vM-0002DK-6Y for grub-devel@gnu.org; Wed, 28 Jul 2010 11:52:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oe8vK-0003gT-QZ for grub-devel@gnu.org; Wed, 28 Jul 2010 11:52:04 -0400 Received: from mail-gy0-f169.google.com ([209.85.160.169]:47811) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oe8vK-0003gO-N1 for grub-devel@gnu.org; Wed, 28 Jul 2010 11:52:02 -0400 Received: by gyb11 with SMTP id 11so2323508gyb.0 for ; Wed, 28 Jul 2010 08:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=uUe3pGKHfxr+K/O5R3Z0JlJUe+sK3N7msvgvOmp/p2I=; b=skQm5/qSG+pmWY8jEA7s9Pn1Kg79bOI/l2FTWCetXvyjWmtxtJOVX2x8RDUdeLqrSt XY0hN83PmSVkLN3pYw/xomYfwzu1AkpCBKpkuhM/zKkiRDUajmrq2bcPdGTKRnUK/ZlW hGUVqHn09yDSlHZW+bBNzngOsTpbvDU5yBlug= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=mQrui2kJIegw5k43KXwuckvgvZYPZI1JXvVk6MRtuXV0ZnS3bDm/WDRzUAhY2c7tIg mNo8ytVXV/ToNo+r4H15wZB0plx2SJhHMijgw4R8AyUm3oaOxuL5qsPR1yt0CsBQf0k5 OlR2mXK0Erv/Wsl97SJvpi+ShkWwZzeJru73o= Received: by 10.100.11.1 with SMTP id 1mr11847860ank.93.1280332321897; Wed, 28 Jul 2010 08:52:01 -0700 (PDT) Received: from [192.168.21.179] (bas1-toronto05-1177663517.dsl.bell.ca [70.49.184.29]) by mx.google.com with ESMTPS id w6sm10960118anb.23.2010.07.28.08.52.01 (version=SSLv3 cipher=RC4-MD5); Wed, 28 Jul 2010 08:52:01 -0700 (PDT) Message-ID: <4C505220.20101@gmail.com> Date: Wed, 28 Jul 2010 11:52:00 -0400 From: Doug Nazar User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.7) Gecko/20100713 Thunderbird/3.1.1 MIME-Version: 1.0 To: grub-devel@gnu.org References: <4C4E2FC5.10607@gmail.com> <20100727152625.GX2632@caffeine.csclub.uwaterloo.ca> <4C4FEF8C.5060200@gmail.com> <20100728150037.GC2632@caffeine.csclub.uwaterloo.ca> In-Reply-To: <20100728150037.GC2632@caffeine.csclub.uwaterloo.ca> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Big Endian fix patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2010 15:52:05 -0000 On 2010-07-28 11:00 AM, Lennart Sorensen wrote: > > OK, no idea how I got by without that. It is currently working for me. > Weird. > > I only use raid1 of course, so that is all I tested with. > It only mattered for multipath. Which is a kind of raid1 setup. Grub doesn't handle it too well since the underlying device is the same and has the same disk number. Before we'd overwrite the old path with the last path found and incorrectly increase nr_devs. With my patch we just ignore additional drives. So we'll die if we lose the path while booting but otherwise it'll find at least one of the paths. >> - Fix the ofdisk_hash system. We weren't making a copy of the devpath so >> never found the cached item again. > Could this have anything to do with why I can't see disks without > devaliases assigned? > No. This would only affect the disk cache subsystem (since the hash struct pointer was used as the disk id) and we'd be comparing the devpath with random memory. > > QEMU/openbios has many bugs unfortunately. If I could make any sense > of the code I would try to fix some of them, but I simply can't follow > that code. > I've got a basic idea how it all hangs together internally and I started to fix a few things in OpenBios but discovered the current source doesn't work with QEMU 0.12.5. "boot" stopped working and if I used "load" it started to work then complained that it was trying to overwrite OpenBios. Since I have no idea how the memory is supposed to be laid out I kinda backed away. Besides, Forth is not my first choice of languages to figure out. > I will give this patch a try on top of mine then and see how it behaves. > Thanks for testing, Doug