From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Oe9Wv-0000rR-Ub for mharc-grub-devel@gnu.org; Wed, 28 Jul 2010 12:30:53 -0400 Received: from [140.186.70.92] (port=51305 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oe9Wt-0000pv-Cr for grub-devel@gnu.org; Wed, 28 Jul 2010 12:30:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oe9Ws-0001ii-As for grub-devel@gnu.org; Wed, 28 Jul 2010 12:30:51 -0400 Received: from mail-gw0-f41.google.com ([74.125.83.41]:64263) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oe9Ws-0001iT-6v for grub-devel@gnu.org; Wed, 28 Jul 2010 12:30:50 -0400 Received: by gwj16 with SMTP id 16so1293756gwj.0 for ; Wed, 28 Jul 2010 09:30:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=Ab2NUqHvWl0fHrGw7FoXTgg1zipDkZzPi6/czF63oWg=; b=owqhmZfw8dDu5mj0MWiGQRPjluABSWsWPFzSQqVpqlTSJMg0Q83fm1GmmdxnCjGpfT PkKzQ54sVfWrys8Lg3Ov3HUMzItuaSjNA/oPqVita8hcGERdz5v/urB99z2kdA9OFQUf juy2FpCxXvZJJ6YK1Lh9edNIFhtsTw9Dpuvlw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=mPaq+eETqd7ZSNCBC6TkEWk3FMlhsUPWxxjUbkoTvnZ6B9eqy05toc6IQTfPq6eOFN GegsNNmjM3gdmf/CNxKR/GxLipQlNoU2vThhhatrNDNv85pXHZL3RbrsxwQSuoWf1JFq h8bOAQQWWnc4X842NYvcvaLQgWLWtmgujawdk= Received: by 10.100.165.18 with SMTP id n18mr11702203ane.252.1280334649367; Wed, 28 Jul 2010 09:30:49 -0700 (PDT) Received: from [192.168.21.179] (bas1-toronto05-1177663517.dsl.bell.ca [70.49.184.29]) by mx.google.com with ESMTPS id d1sm11003445anc.39.2010.07.28.09.30.48 (version=SSLv3 cipher=RC4-MD5); Wed, 28 Jul 2010 09:30:48 -0700 (PDT) Message-ID: <4C505B37.2020009@gmail.com> Date: Wed, 28 Jul 2010 12:30:47 -0400 From: Doug Nazar User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.7) Gecko/20100713 Thunderbird/3.1.1 MIME-Version: 1.0 To: grub-devel@gnu.org References: <4C4E2FC5.10607@gmail.com> <20100727152625.GX2632@caffeine.csclub.uwaterloo.ca> <4C4FEF8C.5060200@gmail.com> <20100728150037.GC2632@caffeine.csclub.uwaterloo.ca> <20100728155158.GE2632@caffeine.csclub.uwaterloo.ca> In-Reply-To: <20100728155158.GE2632@caffeine.csclub.uwaterloo.ca> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Big Endian fix patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2010 16:30:52 -0000 On 2010-07-28 11:51 AM, Lennart Sorensen wrote: > I was wondering a bit why tab completion for ls doesn't work on md 1.x > devices. If I do: > ls (md/0, I get > ls (md/0, > Well since I don't have any partitions, that doesn't help anything). > > Also if I do: > ls (md/0)/ I get nothing. ls (md/0)/ does work, but the tab > completion refuses to believe it could work. I miss tab completition. :) > Think I spotted this by code review. normal/completion.c:250 dir = grub_strchr (current_word, '/'); It looks for a starting '/' but I bet it's hitting the '/' in the new-style md names. It should probably be dir = grub_strchr (current_word + grub_strlen(device), '/'); or something similar. I've just started setting up a test since all my arrays were under an LVM. It'll take me a little while to test with this slow setup. Doug