From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OeB2o-00029t-OE for mharc-grub-devel@gnu.org; Wed, 28 Jul 2010 14:07:54 -0400 Received: from [140.186.70.92] (port=59015 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OeB2m-00028f-3b for grub-devel@gnu.org; Wed, 28 Jul 2010 14:07:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OeB2k-0005Wl-S1 for grub-devel@gnu.org; Wed, 28 Jul 2010 14:07:51 -0400 Received: from mail-vw0-f41.google.com ([209.85.212.41]:46684) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OeB2k-0005Wb-Pd for grub-devel@gnu.org; Wed, 28 Jul 2010 14:07:50 -0400 Received: by vws16 with SMTP id 16so4987930vws.0 for ; Wed, 28 Jul 2010 11:07:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=BYS4RPi2svMm34BP3S9KeoTmWr8piDZZikIgt+5bmoM=; b=hhX5QAeTCfRUCkrwy7qRWdDafdZRoUs4yDm8X5c0hkN1VeE8HflDDHpmip3JgkCMmV FbcTH8xk3GNfq6kJTjhjV50639GTE5JOW7rrqU6ZYoIFoGLakjS9XuzVYMMxDbHApQRc qIVCUoYSA+a4k+Umu09sa1zuFJ8eXe9izUKa8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=EKwVfoge+cspCq3V1+bzPZEUeAR8uTrvM1X9bo1q7xYKyY2G3ha1AECNFGhTsPyvgL DLZ2ue7LQX3I6N7kmzabm+CTOeGPG8d5kbYGkKUM4dU2W/WFK5woODsFr1+V5gYEEwhU hwenizca2YbFKij9STySYfWJEHQVxlPZ9JWQA= Received: by 10.220.171.211 with SMTP id i19mr6387452vcz.252.1280340108417; Wed, 28 Jul 2010 11:01:48 -0700 (PDT) Received: from [192.168.21.179] (bas1-toronto05-1177663517.dsl.bell.ca [70.49.184.29]) by mx.google.com with ESMTPS id l36sm4667987vbi.0.2010.07.28.11.01.47 (version=SSLv3 cipher=RC4-MD5); Wed, 28 Jul 2010 11:01:47 -0700 (PDT) Message-ID: <4C50708A.4030104@gmail.com> Date: Wed, 28 Jul 2010 14:01:46 -0400 From: Doug Nazar User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.7) Gecko/20100713 Thunderbird/3.1.1 MIME-Version: 1.0 To: grub-devel@gnu.org References: <4C4E2FC5.10607@gmail.com> <20100727152625.GX2632@caffeine.csclub.uwaterloo.ca> <4C4FEF8C.5060200@gmail.com> <20100728150037.GC2632@caffeine.csclub.uwaterloo.ca> <20100728155158.GE2632@caffeine.csclub.uwaterloo.ca> <4C505B37.2020009@gmail.com> <20100728170155.GG2632@caffeine.csclub.uwaterloo.ca> <4C5064F0.6000501@gmail.com> <20100728174219.GI2632@caffeine.csclub.uwaterloo.ca> In-Reply-To: <20100728174219.GI2632@caffeine.csclub.uwaterloo.ca> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Big Endian fix patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2010 18:07:53 -0000 On 2010-07-28 1:42 PM, Lennart Sorensen wrote: > I wish the completion would realize that an md device without partitions > (so no partition table) should not complete with a ','. Not sure how > doable that is. > I was just looking at that. In disk/raid.c:129 we set the flag that tells the system to try looking for partitions. I've been debating whether to add code to disk/raid.c to detect if there actually is a partition table (by probing for all known partition types) or fix the tab completion code to offer a ')' also instead of assuming you want a partition. I'm not sure of the GRUB design philosophy, but the first option might be considered a layering violation. Maybe grub_device_open() should check and then clear the flag if it doesn't have a table. Doug