From: Jiri Slaby <jirislaby@gmail.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
devel@driverdev.osuosl.org, ss@aao.gov.au, gregkh@suse.de
Subject: Re: [PATCH] Staging: dt3155: properly export the module parameter
Date: Wed, 28 Jul 2010 22:59:04 +0200 [thread overview]
Message-ID: <4C509A18.3090607@gmail.com> (raw)
In-Reply-To: <201007280948.33247.hartleys@visionengravers.com>
On 07/28/2010 06:48 PM, H Hartley Sweeten wrote:
> Make the module parameter dt3155_major static and add the proper
> wrappers to export it.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Cc: Scott Smedley <ss@aao.gov.au>
> ---
>
> diff --git a/drivers/staging/dt3155/dt3155_drv.c b/drivers/staging/dt3155/dt3155_drv.c
> index 7316996..220eaf9 100644
> --- a/drivers/staging/dt3155/dt3155_drv.c
> +++ b/drivers/staging/dt3155/dt3155_drv.c
> @@ -99,7 +99,9 @@ wait_queue_head_t dt3155_read_wait_queue[MAXBOARDS];
>
> /* set to dynamicaly allocate, but it is tunable: */
> /* insmod DT_3155 dt3155 dt3155_major=XX */
> -int dt3155_major = 0;
> +static int dt3155_major;
> +module_param(dt3155_major, int, 0);
> +MODULE_PARM_DESC(dt3155_major, "Major device number");
Is it necessary in the age of udev?
I would personally get rid of that completely...
regards,
--
js
next prev parent reply other threads:[~2010-07-28 20:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 16:48 [PATCH] Staging: dt3155: properly export the module parameter H Hartley Sweeten
2010-07-28 20:59 ` Jiri Slaby [this message]
2010-07-29 0:55 ` H Hartley Sweeten
2010-07-29 13:09 ` Jiri Slaby
2010-07-29 16:02 ` H Hartley Sweeten
2010-08-03 1:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C509A18.3090607@gmail.com \
--to=jirislaby@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ss@aao.gov.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.