From: "Brian Norris" <norris@broadcom.com>
To: "Florian Fainelli" <ffainelli@freebox.fr>
Cc: David Woodhouse <dwmw2@infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Matthieu CASTET <matthieu.castet@parrot.com>,
Maxime Bizon <mbizon@freebox.fr>
Subject: Re: [PATCH] NAND: add support for reading ONFI parameters from NAND device
Date: Wed, 28 Jul 2010 16:38:01 -0700 [thread overview]
Message-ID: <4C50BF59.3020700@broadcom.com> (raw)
In-Reply-To: <201007290047.06394.ffainelli@freebox.fr>
> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> index a81b185..ad7f58f 100644
> --- a/include/linux/mtd/nand.h
> +++ b/include/linux/mtd/nand.h
<snip>
> @@ -190,6 +194,9 @@ typedef enum {
> /* Device behaves just like nand, but is readonly */
> #define NAND_ROM 0x00000800
>
> +/* Chip supports ONFI */
> +#define NAND_ONFI 0x00001000
I've been wondering: how independent are the flags in include/linux/mtd/bbm.h
and nand.h? I've working on some patches dealing with various such flags. For
instance, I know that the following patch dealt with a potential conflict
between flags in bbm.h and nand.h:
http://lists.infradead.org/pipermail/linux-mtd/2010-June/030703.html
I don't know if there's a possibility of conflict between NAND_BBT_WRITE (bbm.h)
and your new NAND_ONFI (nand.h); both are 0x00001000. I know *some* options are
written into nand_chip->options and later copied onto the options in
nand_bbt_descr->options for BBT usage, e.g., I just rewrote part of this as a
new function nand_create_default_bbt_descr() in nand_bbt.c:
http://lists.infradead.org/pipermail/linux-mtd/2010-July/030911.html
Other pieces of the code perform similar functions at the moment.
Brian
next prev parent reply other threads:[~2010-07-28 23:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 22:47 [PATCH] NAND: add support for reading ONFI parameters from NAND device Florian Fainelli
2010-07-28 23:38 ` Brian Norris [this message]
2010-07-29 8:10 ` Florian Fainelli
2010-07-29 7:54 ` Matthieu CASTET
2010-07-29 8:51 ` Florian Fainelli
2010-08-02 9:25 ` Matthieu CASTET
2010-08-02 11:55 ` Florian Fainelli
2010-08-09 9:25 ` Matthieu CASTET
2010-08-09 9:43 ` Florian Fainelli
2010-08-05 4:54 ` Artem Bityutskiy
2010-08-05 12:56 ` Maxime Bizon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C50BF59.3020700@broadcom.com \
--to=norris@broadcom.com \
--cc=dwmw2@infradead.org \
--cc=ffainelli@freebox.fr \
--cc=linux-mtd@lists.infradead.org \
--cc=matthieu.castet@parrot.com \
--cc=mbizon@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.