From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753534Ab0G2F7x (ORCPT <rfc822;w@1wt.eu>);
	Thu, 29 Jul 2010 01:59:53 -0400
Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:56720 "EHLO
	fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750815Ab0G2F7w (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 29 Jul 2010 01:59:52 -0400
X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.4.0
Message-ID: <4C5118A1.7030204@jp.fujitsu.com>
Date: Thu, 29 Jul 2010 14:58:57 +0900
From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
User-Agent: Thunderbird 2.0.0.23 (Windows/20090812)
MIME-Version: 1.0
To: linux-kernel@vger.kernel.org, hpa@linux.intel.com, tglx@linutronix.de,
        mingo@redhat.com
CC: kaneshige.kenji@jp.fujitsu.com
Subject: Re: [PATCH] x86: ioremap: fix wrong physical address handling in
 PAT code
References: <4C47DDCF.80300@jp.fujitsu.com>
In-Reply-To: <4C47DDCF.80300@jp.fujitsu.com>
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

Does anybody see the following patch? It's obviously a bug. Please apply it.

Thanks,
Yasuaki Ishimatsu

> From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> 
> The following two commits fixed a problem that x86 ioremap() doesn't handle
> physical address higher than 32-bit properly in X86_32 PAE mode.
> 
> ffa71f33a820d1ab3f2fc5723819ac60fb76080b (x86, ioremap: Fix incorrect physical address handling in
> PAE mode)
> 35be1b716a475717611b2dc04185e9d80b9cb693 (x86, ioremap: Fix normal ram range check)
> 
> But these fixes are not enough, since pat_pagerange_is_ram() in PAT code
> also has a same problem. This patch fixes it.
> 
> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> 
> ---
> 
> It is for -tip tree.
> 
> Index: linux-2.6-x86/arch/x86/mm/pat.c
> ===================================================================
> --- linux-2.6-x86.orig/arch/x86/mm/pat.c	2010-07-22 03:04:38.000000000 +0900
> +++ linux-2.6-x86/arch/x86/mm/pat.c	2010-07-22 03:47:36.000000000 +0900
> @@ -158,7 +158,7 @@ static unsigned long pat_x_mtrr_type(u64
>  	return req_type;
>  }
> 
> -static int pat_pagerange_is_ram(unsigned long start, unsigned long end)
> +static int pat_pagerange_is_ram(resource_size_t start, resource_size_t end)
>  {
>  	int ram_page = 0, not_rampage = 0;
>  	unsigned long page_nr;
>