From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Henningsson Subject: Re: [PATCH] Two patches for Alsa-plugins (pulse) Date: Thu, 29 Jul 2010 10:14:22 +0200 Message-ID: <4C51385E.7080102@canonical.com> References: <4C22670D.8010104@epost.diwic.se> <4C2487EA.3090605@epost.diwic.se> <4C376182.5050807@epost.diwic.se> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from adelie.canonical.com (adelie.canonical.com [91.189.90.139]) by alsa0.perex.cz (Postfix) with ESMTP id DA39B10393D for ; Thu, 29 Jul 2010 10:14:24 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Raymond Yau Cc: ALSA Development Mailing List List-Id: alsa-devel@alsa-project.org 2010-07-29 09:11, Raymond Yau skrev: > 2010/7/10 David Henningsson >>> The biggest drawback by this change is that whether the sound goes >>> well or not isn't reported any more to the application layer. >>> It's an unfortunate design, but it's life with PA. >> >> The question is - is there an application that detects the underrun >> condition and actually acts on that condition? If so, this could be a >> regression for that app. For other apps it's an improvement, for the >> reasons originally stated. >> >> > This patch by Lennart Poettering should answer your question > > http://git.alsa-project.org/?p=alsa-plugins.git;a=commit;h=660e0f16145167a966e9b8387e9a8e08274a8f7c Okay, so we've broken XMMS, at least the 2007 version of it? The better solution to this problem would be to add a write_pointer to the xrun callback (and PA's native protocol), so we can detect whether the underrun is obsolete or not and act accordingly. -- David Henningsson, Canonical Ltd. http://launchpad.net/~diwic