All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jaxboe@fusionio.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: fio@vger.kernel.org
Subject: Re: fio crash after running an I/O stress test for about half an  hour
Date: Thu, 29 Jul 2010 10:57:01 +0200	[thread overview]
Message-ID: <4C51425D.2010507@fusionio.com> (raw)
In-Reply-To: <AANLkTimztvyqQPY3dF14awaKKQSm=RMe0Hc6J55O_CAd@mail.gmail.com>

On 07/26/2010 04:17 PM, Bart Van Assche wrote:
> Hello,
> 
> When I run the fio command below, fio triggers a segmentation fault
> after about half an hour. Is this a known issue ?

[snip]

OK, took a quick look. It's an artifact of using norandommap with a
short job like yours, when it finds an alias in the rbtree it only
removes it. So it sticks around in memory and will never get cleaned.
So 10 loops would get you 600k of lost memory, 1000000 would bump you
way into the OOM territory.

The below should fix it, I have committed that fix.

diff --git a/log.c b/log.c
index 5fc8f64..80d3742 100644
--- a/log.c
+++ b/log.c
@@ -231,6 +231,7 @@ restart:
 			assert(ipo->len == __ipo->len);
 			td->io_hist_len--;
 			rb_erase(parent, &td->io_hist_tree);
+			free(__ipo);
 			goto restart;
 		}
 	}

-- 
Jens Axboe


Confidentiality Notice: This e-mail message, its contents and any attachments to it are confidential to the intended recipient, and may contain information that is privileged and/or exempt from disclosure under applicable law. If you are not the intended recipient, please immediately notify the sender and destroy the original e-mail message and any attachments (and any copies that may have been made) from your system or otherwise. Any unauthorized use, copying, disclosure or distribution of this information is strictly prohibited.

  parent reply	other threads:[~2010-07-29  8:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-26 14:17 fio crash after running an I/O stress test for about half an hour Bart Van Assche
2010-07-29  8:46 ` Jens Axboe
2010-07-29  8:57 ` Jens Axboe [this message]
2010-07-31  7:24   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C51425D.2010507@fusionio.com \
    --to=jaxboe@fusionio.com \
    --cc=bvanassche@acm.org \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.