All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kbuild <linux-kbuild@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Denys Vlasenko <vda.linux@googlemail.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Chen Liqin <liqin.chen@sunplusct.com>,
	David Howells <dhowells@redhat.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Haavard Skinnemoen <hskinnemoen@atmel.com>,
	Hirokazu Takata <takata@linux-m32r.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Mike Frysinger <vapier@gentoo.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v2 0/3] update of various kbuild flags to allow user	settings
Date: Thu, 29 Jul 2010 11:00:29 +0200	[thread overview]
Message-ID: <4C51432D.3020600@suse.cz> (raw)
In-Reply-To: <20100728182523.GA29198@merkur.ravnborg.org>

On 28.7.2010 20:25, Sam Ravnborg wrote:
> Denys Vlasenko complained that he could not set
> a moduel specific linker flags on the command line.
> 
> It turned out that the cause of this was kbuild
> that assigned a value to a variables that
> may be modified by the user.
> So any user supplied value would overwrite
> the kbuild assigned value.
> 
> Fix this so we use internal variables for kbuild
> feering up the official variables for use by
> the user.

Acked-by: Michal Marek <mmarek@suse.cz>

but I'll wait a while before applying it so that the arch maintainers
can object to / ack the arch-specific changes.

Michal

  parent reply	other threads:[~2010-07-29  9:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28 18:25 [PATCH v2 0/3] update of various kbuild flags to allow user settings Sam Ravnborg
2010-07-28 18:25 ` Sam Ravnborg
2010-07-28 18:27 ` [PATCH 1/3] kbuild: allow assignment to {A,C,LD}FLAGS_MODULE on the command line Sam Ravnborg
2010-07-28 18:27   ` Sam Ravnborg
2010-07-28 18:32   ` Mike Frysinger
2010-07-28 18:32     ` Mike Frysinger
2010-07-29  9:26   ` Haavard Skinnemoen
2010-07-28 18:28 ` [PATCH 2/3] kbuild: allow assignment to {A,C}FLAGS_KERNEL " Sam Ravnborg
2010-07-28 18:28   ` Sam Ravnborg
2010-07-28 18:28 ` [PATCH 3/3] frv: clean up arch/frv/Makefile Sam Ravnborg
2010-07-28 18:28   ` Sam Ravnborg
2010-07-28 18:30 ` [PATCH v2 0/3] update of various kbuild flags to allow user settings Sam Ravnborg
2010-07-29  9:00 ` Michal Marek [this message]
2010-08-03 12:27   ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C51432D.3020600@suse.cz \
    --to=mmarek@suse.cz \
    --cc=benh@kernel.crashing.org \
    --cc=dhowells@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liqin.chen@sunplusct.com \
    --cc=ralf@linux-mips.org \
    --cc=sam@ravnborg.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=takata@linux-m32r.org \
    --cc=tony.luck@intel.com \
    --cc=vapier@gentoo.org \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.