All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Büsch" <mb@bu3sch.de>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, Larry Finger <Larry.Finger@wfinger.net>
Subject: Re: [PATCH] b43: update hw/fw version info in wiphy struct
Date: Thu, 29 Jul 2010 20:04:52 +0200	[thread overview]
Message-ID: <4C51C2C4.7050207@bu3sch.de> (raw)
In-Reply-To: <1280424853-18954-1-git-send-email-linville@tuxdriver.com> (sfid-20100729_194523_073564_FFFFFFFFA02F8A4A)

On 07/29/2010 07:34 PM, John W. Linville wrote:
> +	wiphy->hw_version = dev->dev->bus->chip_id;

Hm, well. Is hw_version of any use, actually? How does ethtool display
it? I guess it does not use BCD (chip_id is BCD encoded).

What about using the wireless-core revision? It is slightly more usable
than the chip_id.

-- 
Greetings Michael.

  reply	other threads:[~2010-07-29 18:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29 17:34 [PATCH] b43: update hw/fw version info in wiphy struct John W. Linville
2010-07-29 18:04 ` Michael Büsch [this message]
2010-07-29 18:28   ` [PATCH v2] " John W. Linville
2010-07-29 18:44   ` [PATCH] " John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C51C2C4.7050207@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=Larry.Finger@wfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.