All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 8/8] ocfs2/dlm: Add message DLM_QUERY_NODEINFO
Date: Thu, 29 Jul 2010 11:59:06 -0700	[thread overview]
Message-ID: <4C51CF7A.6080609@oracle.com> (raw)
In-Reply-To: <20100729064936.GD2591@laptop.jp.oracle.com>

On 07/28/2010 11:49 PM, Wengang Wang wrote:
> ni_nodenum already checked in the for loop.
>    

For readability.

> Any reason we are not using kzalloc() here and in dlm_send_hbregions()?
>    

ok.

> how about remove this line and
>
> +	int locked = 0, status = -EINVAL;
>    

ok.

  reply	other threads:[~2010-07-29 18:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-23 23:55 [Ocfs2-devel] Global heartbeat - drop#1 Sunil Mushran
2010-07-23 23:55 ` [Ocfs2-devel] [PATCH 1/8] ocfs2/cluster: Add heartbeat mode configfs parameter Sunil Mushran
2010-07-23 23:55 ` [Ocfs2-devel] [PATCH 2/8] ocfs2: Add an incompat feature flag OCFS2_FEATURE_INCOMPAT_CLUSTERINFO Sunil Mushran
2010-07-23 23:55 ` [Ocfs2-devel] [PATCH 3/8] ocfs2: Add support for heartbeat=global mount option Sunil Mushran
2010-07-23 23:55 ` [Ocfs2-devel] [PATCH 4/8] ocfs2/dlm: Expose dlm_protocol in dlm_state Sunil Mushran
2010-07-23 23:55 ` [Ocfs2-devel] [PATCH 5/8] ocfs2/cluster: Get all heartbeat regions Sunil Mushran
2010-07-23 23:55 ` [Ocfs2-devel] [PATCH 6/8] ocfs2/dlm: Add message DLM_QUERY_HBREGION Sunil Mushran
2010-07-28 16:21   ` Wengang Wang
2010-07-28 16:47     ` Sunil Mushran
2010-07-29  5:03       ` Wengang Wang
2010-07-29 17:22         ` Sunil Mushran
2010-07-30  1:55           ` Wengang Wang
2010-07-29  5:08   ` Wengang Wang
2010-07-29 17:24     ` Sunil Mushran
2010-07-23 23:55 ` [Ocfs2-devel] [PATCH 7/8] ocfs2: Print message if user mounts without starting global heartbeat Sunil Mushran
2010-07-23 23:55 ` [Ocfs2-devel] [PATCH 8/8] ocfs2/dlm: Add message DLM_QUERY_NODEINFO Sunil Mushran
2010-07-29  6:49   ` Wengang Wang
2010-07-29 18:59     ` Sunil Mushran [this message]
2010-07-28 14:45 ` [Ocfs2-devel] Global heartbeat - drop#1 Wengang Wang
2010-07-28 16:40   ` Sunil Mushran
2010-07-29  3:08     ` Wengang Wang
2010-07-29 17:28       ` Sunil Mushran
2010-07-30  1:58         ` Wengang Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C51CF7A.6080609@oracle.com \
    --to=sunil.mushran@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.