From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
linux-pm@lists.linux-foundation.org, linux-pci@vger.kernel.org,
Matthew Garrett <mjg59@srcf.ucam.org>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Subject: [PATCH 5/6] PCI: portdrv: disable native hot-plug interrupt
Date: Fri, 30 Jul 2010 15:24:14 +0900 [thread overview]
Message-ID: <4C52700E.3020605@jp.fujitsu.com> (raw)
In-Reply-To: <4C526E3E.3000600@jp.fujitsu.com>
Some BIOS enable PCIe native hot-plug interrupt on _OSC evaluation.
But it should not be enabled until hot-plug service driver is loaded,
otherwise something wrong (ex. interrupt storm) can happen. So disable
hot-plug interrupt at port service probe time.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
---
drivers/pci/pcie/portdrv_core.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
Index: linux-2.6.35-rc6/drivers/pci/pcie/portdrv_core.c
===================================================================
--- linux-2.6.35-rc6.orig/drivers/pci/pcie/portdrv_core.c
+++ linux-2.6.35-rc6/drivers/pci/pcie/portdrv_core.c
@@ -253,8 +253,17 @@ static int get_port_device_capability(st
/* Hot-Plug Capable */
if ((cap_mask & PCIE_PORT_SERVICE_HP) && (reg16 & PCI_EXP_FLAGS_SLOT)) {
pci_read_config_dword(dev, pos + PCI_EXP_SLTCAP, ®32);
- if (reg32 & PCI_EXP_SLTCAP_HPC)
+ if (reg32 & PCI_EXP_SLTCAP_HPC) {
services |= PCIE_PORT_SERVICE_HP;
+ /*
+ * Disable hot-plug interrupts in case the hot-plug
+ * service driver is not loaded.
+ */
+ pos += PCI_EXP_SLTCTL;
+ pci_read_config_word(dev, pos, ®16);
+ reg16 &= ~(PCI_EXP_SLTCTL_CCIE | PCI_EXP_SLTCTL_HPIE);
+ pci_write_config_word(dev, pos, reg16);
+ }
}
/* AER capable */
if ((cap_mask & PCIE_PORT_SERVICE_AER)
next prev parent reply other threads:[~2010-07-30 6:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 21:23 [PATCH] PCI / PCIe: Ask BIOS for control of all native services at once (v4) Rafael J. Wysocki
2010-07-28 21:43 ` Jesse Barnes
2010-07-29 5:03 ` Kenji Kaneshige
2010-07-29 15:45 ` Rafael J. Wysocki
2010-07-30 6:00 ` Kenji Kaneshige
2010-07-30 6:00 ` Kenji Kaneshige
2010-07-30 6:16 ` Kenji Kaneshige
2010-07-30 6:20 ` [PATCH 1/6] ACPI/PCI: cleanup acpi_pci_run_osc Kenji Kaneshige
2010-07-30 12:15 ` Rafael J. Wysocki
2010-07-30 12:15 ` Rafael J. Wysocki
2010-07-30 6:20 ` Kenji Kaneshige
2010-07-30 6:21 ` [PATCH 2/6] ACPI/PCI: do not preserve query result Kenji Kaneshige
2010-07-30 12:42 ` Rafael J. Wysocki
2010-07-30 12:42 ` Rafael J. Wysocki
2010-07-30 6:21 ` Kenji Kaneshige
2010-07-30 6:22 ` [PATCH 3/6] ACPI/PCI: optimize checks in acpi_pci_osc_control_set() Kenji Kaneshige
2010-07-30 6:22 ` Kenji Kaneshige
2010-07-30 12:42 ` Rafael J. Wysocki
2010-07-30 12:42 ` Rafael J. Wysocki
2010-07-30 6:23 ` [PATCH 4/6] ACPI/PCI: ask bios for control of all native services at once Kenji Kaneshige
2010-07-30 8:42 ` Hidetoshi Seto
2010-07-30 8:42 ` Hidetoshi Seto
2010-07-30 8:47 ` [PATCH] portdrv: Don't take control of AER if not required Hidetoshi Seto
2010-07-30 8:47 ` Hidetoshi Seto
2010-07-30 12:46 ` [PATCH 4/6] ACPI/PCI: ask bios for control of all native services at once Rafael J. Wysocki
2010-07-30 12:46 ` Rafael J. Wysocki
2010-07-30 6:23 ` Kenji Kaneshige
2010-07-30 6:24 ` Kenji Kaneshige [this message]
2010-07-30 6:24 ` [PATCH 5/6] PCI: portdrv: disable native hot-plug interrupt Kenji Kaneshige
2010-07-30 6:25 ` [PATCH 6/6] PCI: portdrv: remove module_exit Kenji Kaneshige
2010-07-30 6:25 ` Kenji Kaneshige
2010-07-30 6:16 ` [PATCH] PCI / PCIe: Ask BIOS for control of all native services at once (v4) Kenji Kaneshige
2010-07-30 11:50 ` Rafael J. Wysocki
2010-07-30 11:50 ` Rafael J. Wysocki
2010-07-29 15:45 ` Rafael J. Wysocki
2010-07-29 5:03 ` Kenji Kaneshige
2010-07-28 21:43 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C52700E.3020605@jp.fujitsu.com \
--to=kaneshige.kenji@jp.fujitsu.com \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mjg59@srcf.ucam.org \
--cc=rjw@sisk.pl \
--cc=seto.hidetoshi@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.