Re: [RFC][PATCH 1/2] cifs: show enabled features in /proc

[Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>]

On 07/30/2010 04:39 PM, Jeff Layton wrote:
> On Fri, 30 Jul 2010 15:29:35 +0530
> Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org> wrote:
> 
>> Based on the previous discussions and suggestion by Jeff on providing a way
>> to tell about compiled kernel config options, I wrote a simple patch. It seems
>> useful. But, feel free to ignore this patch if you think it is not..
>>
>> From: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
>> Subject: [RFC][PATCH 1/2] cifs: show enabled features in /proc
>>
>> Here's a simple patch to show the compiled in CIFS features. This patch adds a
>> /proc file called "features" when read will show the features enabled in the
>> running kernel as shown below:
>>
>> 	$cat /proc/fs/cifs/features
>> 	# CIFS features enabled
>> 	dfs spnego fsc
>>
>> This provides a definitive way to tell what features are currently enabled.
>> This could be useful as a debugging information as well.
>>
> 
> Looks good. Now that I've given this more thought though...
> 
> I wonder if this would be better done as a new line near the beginning
> of /proc/fs/cifs/DebugData. Maybe:
> 
> Features: dfs spnego fsc
> 
> People often provide that info already when reporting bugs. We wouldn't
> need to ask for anything new that way.
> 

Good point. Makes it more simpler (no additional proc file needed).
Also,  we need to add xattr and posix as well?

I'll respin it in a while..

Thanks,

-- 
Suresh Jayaraman