From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Alex.Williamson@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode
Date: Sat, 31 Jul 2010 16:40:05 +0200 [thread overview]
Message-ID: <4C5435C5.2040402@redhat.com> (raw)
In-Reply-To: <20100731141944.GC31640@hall.aurel32.net>
On 07/31/10 16:19, Aurelien Jarno wrote:
> On Sat, Jul 31, 2010 at 11:16:45AM +0200, Jes Sorensen wrote:
>> On 07/30/10 23:08, Aurelien Jarno wrote:
>>> Missing braces around the return 0 line.
>>
>> Half the QEMU code base doesn't have braces around single line if
>> statements, including in hw/pci.c. Adding braces here would be inconsistent.
>>
>
> If we follow the coding style in new patches, it will eventually become
> consistent.
>
If you want that, please do it in a separate patch for the entire file,
otherwise it will never become consistent. However it doesn't change the
issue either that putting braces around a single line like this is bad
coding style.
Jes
next prev parent reply other threads:[~2010-07-31 15:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 15:56 [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode Jes.Sorensen
2010-07-30 21:08 ` Aurelien Jarno
2010-07-31 9:16 ` Jes Sorensen
2010-07-31 14:19 ` Aurelien Jarno
2010-07-31 14:40 ` Jes Sorensen [this message]
2010-07-31 15:13 ` Aurelien Jarno
2010-07-31 15:21 ` Jes Sorensen
2010-07-31 15:29 ` Aurelien Jarno
-- strict thread matches above, loose matches on Subject: below --
2010-07-23 12:17 Jes.Sorensen
2010-07-23 15:37 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5435C5.2040402@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Alex.Williamson@redhat.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.