From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39232 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OfDsi-0003hi-P8 for qemu-devel@nongnu.org; Sat, 31 Jul 2010 11:21:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OfDsh-0007xd-JU for qemu-devel@nongnu.org; Sat, 31 Jul 2010 11:21:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20831) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OfDsh-0007xR-BJ for qemu-devel@nongnu.org; Sat, 31 Jul 2010 11:21:47 -0400 Message-ID: <4C543F7E.5020300@redhat.com> Date: Sat, 31 Jul 2010 17:21:34 +0200 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode References: <1279900598-8432-1-git-send-email-Jes.Sorensen@redhat.com> <20100730210847.GD20459@volta.aurel32.net> <4C53E9FD.4070109@redhat.com> <20100731141944.GC31640@hall.aurel32.net> <4C5435C5.2040402@redhat.com> <20100731151318.GF31640@hall.aurel32.net> In-Reply-To: <20100731151318.GF31640@hall.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: Alex.Williamson@redhat.com, qemu-devel@nongnu.org On 07/31/10 17:13, Aurelien Jarno wrote: > On Sat, Jul 31, 2010 at 04:40:05PM +0200, Jes Sorensen wrote: >> If you want that, please do it in a separate patch for the entire file, >> otherwise it will never become consistent. However it doesn't change the >> issue either that putting braces around a single line like this is bad >> coding style. > > We got this discussions numerous times, and I am not going to start it > again. If you want to see the patch applied, just follow the rules. > Then I would like to know why you do not apply this silly rule to every patch submitted. There's patches going in almost every day that doesn't use this hopeless formatting. Jes